RDKB-64347: Fixing coverity issues#1108
Open
vanshika-singhal24 wants to merge 1 commit intordkcentral:developfrom
Open
RDKB-64347: Fixing coverity issues#1108vanshika-singhal24 wants to merge 1 commit intordkcentral:developfrom
vanshika-singhal24 wants to merge 1 commit intordkcentral:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses low-priority Coverity findings by tightening buffer handling in ICMP ping frame construction and by adjusting memory usage / bounds handling in WiFi control queue handlers to avoid unsafe operations.
Changes:
- Harden ICMPv4/ICMPv6 ping frame building by adding a buffer-length parameter and replacing
strcpywith boundedsnprintf. - Update hotspot/LnF processing to avoid using a stack
wifi_vap_info_tinstance by allocatinghotspot_5g_vap_infodynamically and freeing it on all exits. - Update LM Lite host sync to allocate
LM_wifi_hosts_tdynamically and add an in-loop cap check to prevent writing pastLM_MAX_HOSTS_NUM.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
source/stats/wifi_monitor.c |
Adds buffer-length-aware ICMP ping framing and replaces unbounded string copy with bounded formatting. |
source/core/wifi_ctrl_queue_handlers.c |
Adjusts allocations/lifetimes for hotspot/LnF config propagation and LM Lite host sync collection logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reason for change: Fixing Low priority Coverity issues. Test Procedure: Build should be successful and the regression test should also succeed. Risks: Low Priority: P1 Signed-off-by: vanshika_lnu@comcast.com
31f4ae0 to
98a7fbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing Low priority Coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.
Risks: Low
Priority: P1
Signed-off-by: vanshika_lnu@comcast.com