Skip to content

RDKB-64347: Fixing coverity issues#1108

Open
vanshika-singhal24 wants to merge 1 commit intordkcentral:developfrom
vanshika-singhal24:RDKB-StackUse4A
Open

RDKB-64347: Fixing coverity issues#1108
vanshika-singhal24 wants to merge 1 commit intordkcentral:developfrom
vanshika-singhal24:RDKB-StackUse4A

Conversation

@vanshika-singhal24
Copy link
Copy Markdown
Contributor

Reason for change: Fixing Low priority Coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.
Risks: Low
Priority: P1
Signed-off-by: vanshika_lnu@comcast.com

@vanshika-singhal24 vanshika-singhal24 requested a review from a team as a code owner May 5, 2026 09:01
@navyasher navyasher requested a review from Copilot May 5, 2026 09:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses low-priority Coverity findings by tightening buffer handling in ICMP ping frame construction and by adjusting memory usage / bounds handling in WiFi control queue handlers to avoid unsafe operations.

Changes:

  • Harden ICMPv4/ICMPv6 ping frame building by adding a buffer-length parameter and replacing strcpy with bounded snprintf.
  • Update hotspot/LnF processing to avoid using a stack wifi_vap_info_t instance by allocating hotspot_5g_vap_info dynamically and freeing it on all exits.
  • Update LM Lite host sync to allocate LM_wifi_hosts_t dynamically and add an in-loop cap check to prevent writing past LM_MAX_HOSTS_NUM.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
source/stats/wifi_monitor.c Adds buffer-length-aware ICMP ping framing and replaces unbounded string copy with bounded formatting.
source/core/wifi_ctrl_queue_handlers.c Adjusts allocations/lifetimes for hotspot/LnF config propagation and LM Lite host sync collection logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/core/wifi_ctrl_queue_handlers.c Outdated
Comment thread source/stats/wifi_monitor.c
Comment thread source/stats/wifi_monitor.c Outdated
Reason for change: Fixing Low priority Coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.
Risks: Low
Priority: P1
Signed-off-by: vanshika_lnu@comcast.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants