RDKB-62903 TCM RFC update request - configuration by VAP#1105
Draft
Sneha3821 wants to merge 6 commits intordkcentral:developfrom
Draft
RDKB-62903 TCM RFC update request - configuration by VAP#1105Sneha3821 wants to merge 6 commits intordkcentral:developfrom
Sneha3821 wants to merge 6 commits intordkcentral:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the initialization flow for WiFi DB RFC configuration handling, specifically changing when the dbwritten flag is set during init_wifidb_data() while performing RFC config migration/update logic (TCM per-VAP related).
Changes:
- Moves
dbwritten = trueto later in the non-factory-reset initialization path, after potential RFC config update.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
8365
to
8368
| } | ||
| else { | ||
| dbwritten = true; | ||
| if (wifidb_get_rfc_config(0,rfc_param) != 0) { | ||
| wifi_util_error_print(WIFI_DB,"%s:%d: Error getting RFC config\n",__func__, __LINE__); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKB-62903 - TCM RFC update request - configuration by VAP
Reason For Change : TCM RFC is configured at Device.WiFi.Tcm and applies to all VAPs.
Test Procedure: Enable TCM RFC per VAP via DMCLI, verify the update in OVSDB, and confirm TCM logic execution through logs.
dmcli eRT getv Device.WiFi.Tcm
dmcli eRT setv Device.WiFi.Tcm bool true
dmcli eRT getv Device.WiFi.TCM.Open2G
dmcli eRT getv Device.WiFi.TCM.Open5G ``dmcli eRT getv Device.WiFi.TCM.Open6G
dmcli eRT getv Device.WiFi.TCM.Secure2G
dmcli eRT getv Device.WiFi.TCM.Secure5G
dmcli eRT getv Device.WiFi.TCM.Secure6G
/usr/opensync/tools/ovsh s Wifi_Rfc_Config -c -d wifi
/nvram/wifiTCMDbg
wifiTransientClientMgmtCtrl
Priority: P1
Risks: Low
Signed-off-by: Sneha Kannan , [email protected]