Skip to content

RDKB-64347: Fixing coverity issues #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bharathivelp wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

RDKB-64347: Fixing coverity issues #1082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ds/ds_tree.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ static inline ds_tree_node_t *ds_bst_rotate(ds_tree_t *root, ds_tree_node_t *nod
}
else
{
int dir = (node == save->otn_parent->otn_child[1]);
save->otn_parent->otn_child[dir] = save;
int pdir = (node == save->otn_parent->otn_child[1]);
save->otn_parent->otn_child[pdir] = save;
}

return save;
Expand Down
13 changes: 6 additions & 7 deletions source/core/wifi_ctrl_wifiapi_handlers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,12 @@ struct hal_api_info {
{"wifi_getApAssociatedDeviceDiagnosticResult3", 1, "<vap index>"},
};


static char* to_sta_key(uint8_t *mac_address, sta_key_t sta_key) {
snprintf(sta_key, STA_KEY_LEN, "%02x:%02x:%02x:%02x:%02x:%02x",
mac_address[0], mac_address[1], mac_address[2],
mac_address[3], mac_address[4], mac_address[5]);
return sta_key;
}

void wifiapi_printradioconfig(char *buff, unsigned int buff_size, wifi_radio_operationParam_t *radio_config)
{
Expand Down Expand Up @@ -626,12 +631,6 @@ static void wifiapi_handle_get_ApAssocDeviceDiagnosticResult(char **args, unsign
snprintf(result_buf, result_buf_size, "Error: dev_array is NULL\n");
return;
}
char* to_sta_key(uint8_t *mac_address, sta_key_t sta_key) {
snprintf(sta_key, STA_KEY_LEN, "%02x:%02x:%02x:%02x:%02x:%02x",
mac_address[0], mac_address[1], mac_address[2],
mac_address[3], mac_address[4], mac_address[5]);
return sta_key;
}
snprintf(result_buf, result_buf_size, "diag result: number of devs: %d\n", num_devs);
for (unsigned int i = 0; i < num_devs; i++) {
snprintf(result_buf, result_buf_size,
Expand Down
Loading