Skip to content

RDKB-36610: Debug #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MothiShree wants to merge 4 commits into
base: main
Choose a base branch
from
+47 −58
Draft

RDKB-36610: Debug #1066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7bdd897
RDKB-36610: Debug
MothiShree Mar 9, 2026
8f635d3
RDKB-36610: Debug
MothiShree Apr 17, 2026
0e29eb6
RDKB-36610: Debug
MothiShree Apr 17, 2026
64302e3
RDKB-36610: Debug
MothiShree Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions source/core/services/vap_svc_public.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ int vap_svc_public_update(vap_svc_t *svc, unsigned int radio_index, wifi_vap_inf
&map->vap_array[i].u.bss_info.interworking);
get_wifidb_obj()->desc.update_wifi_anqp_cfg_fn(map->vap_array[i].vap_name,
&map->vap_array[i].u.bss_info.interworking);
get_wifidb_obj()->desc.update_wifi_cac_cfg_fn(p_tgt_vap_map);
if(map->vap_array[i].u.bss_info.mgmtPowerControl != 0) {
scheduler_add_timer_task(ctrl->sched, FALSE, NULL, update_managementFramePower, NULL, MFPC_TIMER * 1000, 1, FALSE);
}
Expand Down
34 changes: 22 additions & 12 deletions source/dml/dml_webconfig/dml_onewifi_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1511,27 +1511,28 @@ wifi_GASConfiguration_t* get_dml_wifi_gas_config(void)
int is_vap_config_changed;
int is_vap_cac_config_changed;

void set_dml_cache_vap_config_changed(uint8_t vap_index)
static void debug_log_onewifi(const char *run_id, const char *hypothesis_id, const char *location, const char *message, int v1, int v2)
{
int subdoc = 0;
unsigned int num_radios = get_num_radio_dml();
FILE *f = fopen("/mnt/home/mmalla642/main_q2/.cursor/debug-bfb9c3.log", "a");
long long ts_ms = (long long)time(NULL) * 1000;

if (vap_index < (num_radios * MAX_NUM_VAP_PER_RADIO)) {
get_subdoc_name_from_vap_index(vap_index,&subdoc);
is_vap_config_changed = is_vap_config_changed|subdoc;
return;
} else {
wifi_util_error_print(WIFI_DMCLI, "%s: wrong vap_index %d\n", __FUNCTION__, vap_index);
if (f == NULL) {
return;
}

fprintf(f, "{\"sessionId\":\"bfb9c3\",\"runId\":\"%s\",\"hypothesisId\":\"%s\",\"location\":\"%s\",\"message\":\"%s\",\"data\":{\"v1\":%d,\"v2\":%d},\"timestamp\":%lld}\n",
run_id, hypothesis_id, location, message, v1, v2, ts_ms);
fclose(f);
}

void set_cac_cache_changed(uint8_t vap_index)
void set_dml_cache_vap_config_changed(uint8_t vap_index)
{
int subdoc = 0;
unsigned int num_radios = get_num_radio_dml();

if (vap_index < (num_radios * MAX_NUM_VAP_PER_RADIO)) {
is_vap_cac_config_changed = 1;
get_subdoc_name_from_vap_index(vap_index,&subdoc);
is_vap_config_changed = is_vap_config_changed|subdoc;
return;
} else {
wifi_util_error_print(WIFI_DMCLI, "%s: wrong vap_index %d\n", __FUNCTION__, vap_index);
Expand All @@ -1544,6 +1545,12 @@ int push_subdoc_to_one_wifidb(uint8_t subdoc)
webconfig_subdoc_data_t *data = NULL;
char *str = NULL;

if (subdoc == webconfig_subdoc_type_cac) {
// #region agent log
debug_log_onewifi("pre-fix", "H4", "dml_onewifi_api.c:push_subdoc_to_one_wifidb", "CAC subdoc push started", (int)subdoc, 0);
// #endregion
}

data = (webconfig_subdoc_data_t *)malloc(sizeof(webconfig_subdoc_data_t));
if (data == NULL) {
wifi_util_error_print(WIFI_DMCLI, "%s:%d Failed to allocate memory\n", __func__, __LINE__);
Expand Down Expand Up @@ -1612,6 +1619,9 @@ int push_rfc_dml_cache_to_one_wifidb(bool rfc_value,wifi_event_subtype_t rfc)

int push_vap_dml_cache_to_one_wifidb()
{
// #region agent log
debug_log_onewifi("pre-fix", "H3", "dml_onewifi_api.c:push_vap_dml_cache_to_one_wifidb", "Push VAP cache invoked", is_vap_config_changed, is_vap_cac_config_changed);
// #endregion

if(is_vap_config_changed == FALSE && is_vap_cac_config_changed == FALSE)
{
Expand Down Expand Up @@ -1647,7 +1657,7 @@ int push_vap_dml_cache_to_one_wifidb()
wifi_util_info_print(WIFI_DMCLI, "%s: Subdoc webconfig_subdoc_type_lnf DML Modified \n", __FUNCTION__);
push_subdoc_to_one_wifidb(webconfig_subdoc_type_lnf);
}
if(is_vap_cac_config_changed) {
if (is_vap_cac_config_changed) {
wifi_util_info_print(WIFI_DMCLI, "%s: Subdoc webconfig_subdoc_type_cac DML Modified \n", __FUNCTION__);
push_subdoc_to_one_wifidb(webconfig_subdoc_type_cac);
}
Expand Down
44 changes: 14 additions & 30 deletions source/dml/tr_181/ml/cosa_wifi_dml.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10549,7 +10549,6 @@ PreAssocDeny_SetParamIntValue
}
wifi_util_dbg_print(WIFI_DMCLI,"%s:%d: DMCLI value set :%d \n",__func__, __LINE__,iValue);
vapInfo->u.bss_info.preassoc.time_ms = iValue;
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}
Expand All @@ -10561,7 +10560,6 @@ PreAssocDeny_SetParamIntValue
}
wifi_util_dbg_print(WIFI_DMCLI,"%s:%d: DMCLI value set :%d \n",__func__, __LINE__,iValue);
vapInfo->u.bss_info.preassoc.min_num_mgmt_frames = iValue;
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;

Expand Down Expand Up @@ -10678,7 +10676,7 @@ PreAssocDeny_SetParamStringValue

if (strcmp(pString, "disabled") == 0) {
snprintf(vapInfo->u.bss_info.preassoc.rssi_up_threshold, sizeof(vapInfo->u.bss_info.preassoc.rssi_up_threshold), "%s", "disabled");
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}

Expand All @@ -10696,7 +10694,7 @@ PreAssocDeny_SetParamStringValue
}

snprintf(vapInfo->u.bss_info.preassoc.rssi_up_threshold, sizeof(vapInfo->u.bss_info.preassoc.rssi_up_threshold), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}

Expand All @@ -10708,7 +10706,7 @@ PreAssocDeny_SetParamStringValue

if (strcmp(pString, "disabled") == 0) {
snprintf(vapInfo->u.bss_info.preassoc.snr_threshold, sizeof(vapInfo->u.bss_info.preassoc.snr_threshold), "%s", "disabled");
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}

Expand All @@ -10726,7 +10724,7 @@ PreAssocDeny_SetParamStringValue
}

snprintf(vapInfo->u.bss_info.preassoc.snr_threshold, sizeof(vapInfo->u.bss_info.preassoc.snr_threshold), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}

Expand All @@ -10739,7 +10737,7 @@ PreAssocDeny_SetParamStringValue

if (strcmp(pString, "disabled") == 0) {
snprintf(vapInfo->u.bss_info.preassoc.cu_threshold, sizeof(vapInfo->u.bss_info.preassoc.cu_threshold), "%s", "disabled");
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}

Expand All @@ -10757,7 +10755,7 @@ PreAssocDeny_SetParamStringValue
}

snprintf(vapInfo->u.bss_info.preassoc.cu_threshold, sizeof(vapInfo->u.bss_info.preassoc.cu_threshold), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}
/* check the parameter name and return the corresponding value */
Expand All @@ -10771,7 +10769,6 @@ PreAssocDeny_SetParamStringValue

if (strcmp(pString, "disabled") == 0) {
snprintf(vapInfo->u.bss_info.preassoc.basic_data_transmit_rates, sizeof(vapInfo->u.bss_info.preassoc.basic_data_transmit_rates), "%s", "disabled");
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}
Expand All @@ -10782,7 +10779,6 @@ PreAssocDeny_SetParamStringValue
return FALSE;
}
snprintf(vapInfo->u.bss_info.preassoc.basic_data_transmit_rates, sizeof(vapInfo->u.bss_info.preassoc.basic_data_transmit_rates), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}
Expand All @@ -10800,7 +10796,6 @@ PreAssocDeny_SetParamStringValue

if (strcmp(pString, "disabled") == 0) {
snprintf(vapInfo->u.bss_info.preassoc.operational_data_transmit_rates, sizeof(vapInfo->u.bss_info.preassoc.operational_data_transmit_rates), "%s", "disabled");
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}
Expand All @@ -10812,7 +10807,6 @@ PreAssocDeny_SetParamStringValue
}

snprintf(vapInfo->u.bss_info.preassoc.operational_data_transmit_rates, sizeof(vapInfo->u.bss_info.preassoc.operational_data_transmit_rates), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
Comment on lines 10809 to 10811
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_cac_cache_changed() is still being called in this function (e.g., in the TcmExpWeightage/TcmGradientThreshold default-value branches), but the implementation was removed from dml_onewifi_api.c. This will cause a build failure due to an undefined symbol / implicit declaration. Replace these remaining call sites with the new tracking mechanism (or restore the function) so the file compiles and links cleanly.

Copilot uses AI. Check for mistakes.
}
Expand All @@ -10828,7 +10822,6 @@ PreAssocDeny_SetParamStringValue

if (strcmp(pString, "disabled") == 0) {
snprintf(vapInfo->u.bss_info.preassoc.supported_data_transmit_rates, sizeof(vapInfo->u.bss_info.preassoc.supported_data_transmit_rates), "%s", "disabled");
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}
Expand All @@ -10840,7 +10833,6 @@ PreAssocDeny_SetParamStringValue
}

snprintf(vapInfo->u.bss_info.preassoc.supported_data_transmit_rates, sizeof(vapInfo->u.bss_info.preassoc.supported_data_transmit_rates), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}
Expand All @@ -10856,7 +10848,6 @@ PreAssocDeny_SetParamStringValue

if (strcmp(pString, "disabled") == 0) {
snprintf(vapInfo->u.bss_info.preassoc.minimum_advertised_mcs, sizeof(vapInfo->u.bss_info.preassoc.minimum_advertised_mcs), "%s", "disabled");
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}
Expand All @@ -10874,7 +10865,6 @@ PreAssocDeny_SetParamStringValue
}

snprintf(vapInfo->u.bss_info.preassoc.minimum_advertised_mcs, sizeof(vapInfo->u.bss_info.preassoc.minimum_advertised_mcs), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}
Expand All @@ -10888,12 +10878,10 @@ PreAssocDeny_SetParamStringValue

if (strcmp(pString, "disabled") == 0) {
snprintf(vapInfo->u.bss_info.preassoc.sixGOpInfoMinRate, sizeof(vapInfo->u.bss_info.preassoc.sixGOpInfoMinRate), "%s", "disabled");
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}
snprintf(vapInfo->u.bss_info.preassoc.sixGOpInfoMinRate, sizeof(vapInfo->u.bss_info.preassoc.sixGOpInfoMinRate), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}
Expand All @@ -10907,13 +10895,11 @@ PreAssocDeny_SetParamStringValue
if (strcmp(pString, TCM_EXP_WEIGHTAGE) == 0) {
wifi_util_dbg_print(WIFI_DMCLI,"%s:%d Trying to set default value \n", __FUNCTION__,__LINE__);
strncpy(vapInfo->u.bss_info.preassoc.tcm_exp_weightage, TCM_EXP_WEIGHTAGE, sizeof(vapInfo->u.bss_info.preassoc.tcm_exp_weightage));
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}

snprintf(vapInfo->u.bss_info.preassoc.tcm_exp_weightage, sizeof(vapInfo->u.bss_info.preassoc.tcm_exp_weightage), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}
Expand All @@ -10927,12 +10913,10 @@ PreAssocDeny_SetParamStringValue
if (strcmp(pString, TCM_GRADIENT_THRESHOLD) == 0) {
wifi_util_dbg_print(WIFI_DMCLI,"%s:%d trying to set default value \n", __FUNCTION__,__LINE__);
strncpy(vapInfo->u.bss_info.preassoc.tcm_gradient_threshold, TCM_GRADIENT_THRESHOLD, sizeof(vapInfo->u.bss_info.preassoc.tcm_gradient_threshold));
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}
snprintf(vapInfo->u.bss_info.preassoc.tcm_gradient_threshold, sizeof(vapInfo->u.bss_info.preassoc.tcm_gradient_threshold), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}
Expand Down Expand Up @@ -11504,7 +11488,7 @@ PostAssocDisc_SetParamStringValue

if (strcmp(pString, "disabled") == 0) {
snprintf(vapInfo->u.bss_info.postassoc.rssi_up_threshold, sizeof(vapInfo->u.bss_info.postassoc.rssi_up_threshold), "%s", "disabled");
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}

Expand All @@ -11522,7 +11506,7 @@ PostAssocDisc_SetParamStringValue
}

snprintf(vapInfo->u.bss_info.postassoc.rssi_up_threshold, sizeof(vapInfo->u.bss_info.postassoc.rssi_up_threshold), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}

Expand All @@ -11546,7 +11530,7 @@ PostAssocDisc_SetParamStringValue
}

snprintf(vapInfo->u.bss_info.postassoc.sampling_interval, sizeof(vapInfo->u.bss_info.postassoc.sampling_interval), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}

Expand All @@ -11558,7 +11542,7 @@ PostAssocDisc_SetParamStringValue

if (strcmp(pString, "disabled") == 0) {
snprintf(vapInfo->u.bss_info.postassoc.snr_threshold, sizeof(vapInfo->u.bss_info.postassoc.snr_threshold), "%s", "disabled");
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}

Expand All @@ -11576,7 +11560,7 @@ PostAssocDisc_SetParamStringValue
}

snprintf(vapInfo->u.bss_info.postassoc.snr_threshold, sizeof(vapInfo->u.bss_info.postassoc.snr_threshold), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}

Expand All @@ -11600,7 +11584,7 @@ PostAssocDisc_SetParamStringValue
}

snprintf(vapInfo->u.bss_info.postassoc.sampling_count, sizeof(vapInfo->u.bss_info.postassoc.sampling_count), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}

Expand All @@ -11612,7 +11596,7 @@ PostAssocDisc_SetParamStringValue

if (strcmp(pString, "disabled") == 0) {
snprintf(vapInfo->u.bss_info.postassoc.cu_threshold, sizeof(vapInfo->u.bss_info.postassoc.cu_threshold), "%s", "disabled");
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}

Expand All @@ -11630,7 +11614,7 @@ PostAssocDisc_SetParamStringValue
}

snprintf(vapInfo->u.bss_info.postassoc.cu_threshold, sizeof(vapInfo->u.bss_info.postassoc.cu_threshold), "%s", pString);
set_cac_cache_changed(instance_number - 1);
set_dml_cache_vap_config_changed(instance_number - 1);
return TRUE;
}

Expand Down
1 change: 0 additions & 1 deletion source/dml/tr_181/sbapi/cosa_wifi_apis.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,6 @@ ANSC_STATUS cosaWifiRadioRestart()
if (rdk_vap_info != NULL) {
rdk_vap_info->force_apply = true;
set_dml_cache_vap_config_changed(vap);
set_cac_cache_changed(vap);
}
}
wifi_util_info_print(WIFI_DMCLI, "%s:%d Resetting Radio and VAP stats success\n", __func__,
Expand Down
Loading
Loading