RDKEMW-10995: Fix to prevent double close issue#410
Merged
goruklu merged 2 commits intordkcentral:release/v3.16from Feb 10, 2026
Merged
RDKEMW-10995: Fix to prevent double close issue#410goruklu merged 2 commits intordkcentral:release/v3.16from
goruklu merged 2 commits intordkcentral:release/v3.16from
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a file-descriptor lifecycle issue in the Logging plugin’s FileSink to prevent accidentally closing the same FD twice, especially when the output file falls back to /dev/null.
Changes:
- Treat fd
0as valid by switching fd checks from> 0to>= 0in the/dev/nullfallback path. - Update destructor close logic to avoid double-closing when
mOutputFileFdaliasesmDevNullFd. - Improve close error reporting by distinguishing “output file” vs “/dev/null” failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sasikumartech
approved these changes
Feb 10, 2026
B-Larsen
approved these changes
Feb 10, 2026
goruklu
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added proper fd validation and avoids closing the same fd twice
Type of Change
Requires Bitbake Recipe changes?
meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updatingSRC_REV)