Skip to content

Conversation

@ks734
Copy link
Contributor

@ks734 ks734 commented Feb 10, 2026

Description

Added proper fd validation and avoids closing the same fd twice

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (doesn't fit into the above categories - e.g. documentation updates)

Requires Bitbake Recipe changes?

  • The base Bitbake recipe (meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updating SRC_REV)

Copilot AI review requested due to automatic review settings February 10, 2026 08:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a file-descriptor lifecycle issue in the Logging plugin’s FileSink to prevent accidentally closing the same FD twice, especially when the output file falls back to /dev/null.

Changes:

  • Treat fd 0 as valid by switching fd checks from > 0 to >= 0 in the /dev/null fallback path.
  • Update destructor close logic to avoid double-closing when mOutputFileFd aliases mDevNullFd.
  • Improve close error reporting by distinguishing “output file” vs “/dev/null” failures.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@goruklu goruklu merged commit f77bf17 into rdkcentral:release/v3.16 Feb 10, 2026
56 of 59 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants