Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading mongo client to version compatible with server v8 #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

josemduarte
Copy link
Member

Mongo client comes via spring-boot-starter-data-mongodb-reactive (it uses mongo client v 4.11.1). I checked the latest version of spring-boot-starter-data-mongodb-reactive but it also comes with the same version of mongo client. Thus I decided to go with adding the explicit dependency. Is that the way to go @bioinsilico ?

Note I couldn't test it because I couldn't start the server locally, but the error seems unrelated: Parameter 0 of constructor in org.rcsb.rcsbsequencecoordinates.controller.GraphQlRSocketController required a bean of type 'org.springframework.graphql.ExecutionGraphQlService' that could not be found.

Copy link
Member

@bioinsilico bioinsilico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @josemduarte. I don't know if it is the way to go. I guess the best practice is to use whatever comes with the spring mongo reactive module but if the v5.2.0 is really needed I don't see any other way.

I tested the new version and seems to be working.

@josemduarte
Copy link
Member Author

@bioinsilico I've tested again and this time I could actually run the service. I got a runtime ClassNotFoundError, like you were getting.

Now I've pushed a commit that seems to fix the issue. I tested against Mongo servers v4 and v8 and it worked fine for both. What do you think?

@bioinsilico
Copy link
Member

Thank you, @josemduarte. I tested for v4 and v8 and it worked.

Copy link
Member

@bioinsilico bioinsilico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josemduarte I think this is safe to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants