Support the array PROMPT_COMMAND (bash >= 5.1) #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
commented
Mar 6, 2023
Contributor
Author
akinomyoga
force-pushed
the
array-PROMPT_COMMAND
branch
from
203ad78 to
a16daaf
Compare
dimo414
reviewed
Mar 7, 2023
akinomyoga
force-pushed
the
array-PROMPT_COMMAND
branch
2 times, most recently
from
219ae02 to
b7fb4ae
Compare
akinomyoga
force-pushed
the
array-PROMPT_COMMAND
branch
from
b7fb4ae to
788214a
Compare
Contributor
Author
|
I have rebased the PR on top of the latest master (with #128 included). |
akinomyoga
force-pushed
the
array-PROMPT_COMMAND
branch
from
788214a to
7fb59da
Compare
akinomyoga
force-pushed
the
array-PROMPT_COMMAND
branch
from
7fb59da to
0d2b598
Compare
Owner
|
👍 thanks for the PR @akinomyoga! Merging. |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue I reported in #130 (comment).
ShellCheck seems to have started to complain about
-lt,-eq, etc. in the conditional command[[ ... ]], so I also included a commit (77aec5f) to workaround the shellcheck warning.