Fix WEBSOCKET_HOST not being respected in RPC fallback #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When WASM is not available, the application falls back to RPC calls for game mechanics. However, the RPC calls were always using the relative path '/api/rpc' and ignoring the WEBSOCKET_HOST environment variable. This fix ensures that: - RPC calls respect WEBSOCKET_HOST when it's set - WebSocket URLs (wss://, ws://) are properly converted to HTTP URLs (https://, http://) - The correct /api/rpc path is appended based on the URL structure - Comprehensive tests verify the URL construction for both WebSocket and RPC 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> :house: Remote-Dev: homespace
- Fixed prefer-const lint error in WasmOrRpcProvider.test.tsx - Applied prettier formatting to both test files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> :house: Remote-Dev: homespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When WASM is not available, the application falls back to RPC calls for game mechanics. However, the RPC calls were always using the relative path '/api/rpc' and ignoring the WEBSOCKET_HOST environment variable.
This fix ensures that:
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]
🏠 Remote-Dev: homespace