Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add group member invite modal #375

Merged
merged 9 commits into from
Oct 6, 2023
Merged

feat: add group member invite modal #375

merged 9 commits into from
Oct 6, 2023

Conversation

rsbh
Copy link
Member

@rsbh rsbh commented Oct 4, 2023 •
edited
Loading

  1. Add roles filter to org and project member invite modal.
  2. Add support for enter key in email login and otp form submit.
  3. Add Headers to table columns
  4. Add Group member invite modal, add support to add custom role while adding user

TODO:

  1. update select in apsara to handle large list. chore(select): export scroll buttons and viewport apsara#86 ✅
  2. Create policy api for group not working fix: allow user to create group policy if they have update permission #376 ✅

@vercel
Copy link

vercel bot commented Oct 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 11:33am

@rsbh rsbh force-pushed the fix_sdk_ui_invite_role_filters branch from 183379d to ff1e84b Compare October 5, 2023 08:13
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 5, 2023
View reviewed changes
sdks/js/packages/core/react/components/onboarding/magiclink-verify.tsx
}
}, [otp]);
// @ts-ignore
window.location = redirectURL ? redirectURL : window.location.origin;

Check warning

Code scanning / CodeQL

Client-side cross-site scripting Medium

Cross-site scripting vulnerability due to
user-provided value
Loading
.
sdks/js/packages/core/react/components/onboarding/magiclink-verify.tsx
}
}, [otp]);
// @ts-ignore
window.location = redirectURL ? redirectURL : window.location.origin;

Check warning

Code scanning / CodeQL

Client-side URL redirect Medium

Untrusted URL redirection depends on a
user-provided value
Loading
.
@rsbh rsbh marked this pull request as ready for review October 5, 2023 11:32
@rsbh rsbh requested a review from pyadav October 5, 2023 11:32
@rsbh rsbh force-pushed the fix_sdk_ui_invite_role_filters branch from 533c54e to dd87a72 Compare October 5, 2023 13:53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6420016655

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.965%
Totals Coverage Status
Change from base Build 6417784860: 0.0%
Covered Lines: 5678
Relevant Lines: 11141
💛 - Coveralls

@rsbh rsbh merged commit ef611ab into main Oct 6, 2023
9 checks passed
@rsbh rsbh deleted the fix_sdk_ui_invite_role_filters branch October 6, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyadav pyadav Awaiting requested review from pyadav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsbh @coveralls