[core] Move locations when recovering and correct logs + comments #52394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dayshah <[email protected]>
Signed-off-by: dayshah <[email protected]>
jjyao
approved these changes
Apr 21, 2025
ktyxx
pushed a commit
to ktyxx/ray
that referenced
this pull request
Apr 29, 2025
…y-project#52394) Signed-off-by: dayshah <[email protected]>
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
May 5, 2025
…y-project#52394) Signed-off-by: dayshah <[email protected]>
zhaoch23
pushed a commit
to Bye-legumes/ray
that referenced
this pull request
May 14, 2025
…y-project#52394) Signed-off-by: dayshah <[email protected]> Signed-off-by: zhaoch23 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Moving locations through to avoid copies on recovery path.
Correcting a couple of old log messages and comments to be more accurate to what's actually happening.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.