[Fix][Core] Use asyncio.Event instead of AsyncioActorExit exception to terminate async actor #49918
+126
−90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When an asyncio task creates another asyncio task, raising
AsyncioActorExit
cannot make the caller exit because they are not the same task. Therefore, this PR removes theAsyncioActorExit
custom exception and usesasyncio.Event
for synchronization among multiple asyncio tasks. This ensures that even if the user creates a different asyncio task and callsexit_actor
within it, the actor can still exit correctly.Related issue number
Closes: #49451
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.