[doc][core][compiled graphs] Doc for execution and failure semantics #49904
+74
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayshah
approved these changes
Jan 17, 2025
Comment on lines
49
to
54
| try: | ||
| # Check for live actors. | ||
| ray.get(actor.echo.remote("ping")) | ||
| live_actors.append(actor) | ||
| except ray.exceptions.RayActorError: | ||
| pass |
There was a problem hiding this comment.
indents in the try except?
There was a problem hiding this comment.
Thanks for catching it. I think the format messed up when I copied it over. Fixed.
ruisearch42
requested review from
sven1977,
simonsays1980,
a team and
hongchaodeng
as code owners
Signed-off-by: Rui Qiao <[email protected]>
Signed-off-by: Rui Qiao <[email protected]>
ruisearch42
force-pushed
the
doc_execution
branch
from
0050c98 to
fe19a54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add doc for beta release
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.