Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][compiled graphs] Remove microbenchmark unstable #49901

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

ruisearch42
Copy link
Contributor

Why are these changes needed?

Clean up the "Microbenchmark unstable" benchmarks: these are basically used for Compiled Graphs.
And we have already set up compiled graphs microbenchmarks the run the same tests.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rynewang rynewang enabled auto-merge (squash) January 17, 2025 00:13
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jan 17, 2025
@rynewang rynewang merged commit dbf1d92 into ray-project:master Jan 17, 2025
6 checks passed
ruisearch42 added a commit to ruisearch42/ray that referenced this pull request Jan 17, 2025
…9901)

Clean up the "Microbenchmark unstable" benchmarks: these are basically
used for Compiled Graphs.
And we have already set up compiled graphs microbenchmarks the run the
same tests.

Signed-off-by: Rui Qiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants