-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpin pyarrow for windows #42097
unpin pyarrow for windows #42097
Conversation
step 1: release the pin. Let's see what tests fail? |
I also ran the test added in #29993 locally and it passed. |
cc @anyscalesam |
I think releasing the pin is enough to solve the issue. |
Signed-off-by: mattip <[email protected]>
I don't think the CI failure is related. It would be nice to get some eyes on this. |
CI failure is likely unrelated. Updating branch to re-run |
Contents of PR LGTM - I triggered a postmerge test to see how things look on windows tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @c21 to approve and merge
Could we pick that for 2.9.2? |
When will this fix be released. It introduced installation issue for AutoGluon on Windows platform with Python 3.11 |
Why are these changes needed?
Toward fixing #38300
PR #29993 added a local ray fix for issue apache/arrow#26685, but at the time windows failed the tests with pyarrow7. In issue #38300 the suggested fix was
_register_arrow_data_serializer()
, and include an environment variable to override the Pyarrow version checkChecks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.