[core] Cover cpplint for ray/src/ray/internal (#50662)

Signed-off-by: win5923 <[email protected]>
ray-project · Feb 25, 2025 · 7c8e1c8 · 7c8e1c8
1 parent 62a68ae
commit 7c8e1c8
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -47,7 +47,7 @@ repos:
     hooks:
       - id: cpplint
         args: ["--filter=-whitespace/braces,-whitespace/line_length,-build/c++11,-build/c++14,-build/c++17,-readability/braces,-whitespace/indent_namespace,-runtime/int,-runtime/references,-build/include_order"]
-        files: ^src/ray/(util|raylet_client|scheduling|pubsub|rpc(?:/.*)?)/.*\.(h|cc)$
+        files: ^src/ray/(util|raylet_client|internal|scheduling|pubsub|rpc(?:/.*)?)/.*\.(h|cc)$
 
   - repo: https://github.com/keith/pre-commit-buildifier
     rev: 8.0.1

diff --git a/src/ray/internal/internal.cc b/src/ray/internal/internal.cc
@@ -14,6 +14,12 @@
 
 #include "ray/internal/internal.h"
 
+#include <memory>
+#include <string>
+#include <unordered_map>
+#include <utility>
+#include <vector>
+
 #include "ray/core_worker/core_worker.h"
 
 namespace ray {
@@ -38,14 +44,14 @@ std::vector<rpc::ObjectReference> SendInternal(
   TaskOptions options{name, return_num, resources};
 
   char meta_data[3] = {'R', 'A', 'W'};
-  std::shared_ptr<LocalMemoryBuffer> meta =
-      std::make_shared<LocalMemoryBuffer>((uint8_t *)meta_data, 3, true);
+  auto meta = std::make_shared<LocalMemoryBuffer>(
+      reinterpret_cast<uint8_t *>(meta_data), 3, true);
 
   std::vector<std::unique_ptr<TaskArg>> args;
   if (function.GetLanguage() == Language::PYTHON) {
     auto dummy = "__RAY_DUMMY__";
-    std::shared_ptr<LocalMemoryBuffer> dummyBuffer =
-        std::make_shared<LocalMemoryBuffer>((uint8_t *)dummy, 13, true);
+    auto dummyBuffer = std::make_shared<LocalMemoryBuffer>(
+        reinterpret_cast<uint8_t *>(const_cast<char *>(dummy)), 13, true);
     args.emplace_back(new TaskArgByValue(std::make_shared<RayObject>(
         std::move(dummyBuffer), meta, std::vector<rpc::ObjectReference>(), true)));
   }

diff --git a/src/ray/internal/internal.h b/src/ray/internal/internal.h
@@ -13,6 +13,11 @@
 // limitations under the License.
 
 #pragma once
+
+#include <memory>
+#include <string>
+#include <vector>
+
 #include "ray/common/buffer.h"
 #include "ray/common/id.h"
 #include "ray/core_worker/common.h"