[Config]: standardize quoting style in Kubernetes manifests (#4353) #4359
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
Hi @DejusDevspace , thanks for your help! Could you also run a search using 
|
|
Alright. I'll do that. Thank you |
| annotations: | ||
| gke-gcsfuse/volumes: "true" | ||
| gke-gcsfuse/cpu-limit: "0" | ||
| gke-gcsfuse/memory-limit: 5Gi |
There was a problem hiding this comment.
@CheyuWu @DejusDevspace Shouldn't this also be in double quotes? Same for the next line as well.
There was a problem hiding this comment.
Yes, I think it should be. I went through an earlier PR that quoted resource values in sample kubernetes manifests, and I believe this should be the same case.
I'll work on that, too. Thanks for pointing it out.
ray-operator/config/samples/ray-data-image-resize/ray-data-image-resize-gcsfusecsi-job.yaml
Outdated
Show resolved
Hide resolved
|
@DejusDevspace Would be better to clean up the commit history by squashing the commits into a single one. |
DejusDevspace
force-pushed
the
refactor/kubernetes-manifests
branch
from
74a6b11 to
0b7a897
Compare
|
@kash2104 Done. |
|
@DejusDevspace Just tick the test checkboxes in the PR description. |
|
@kash2104 Done. |
github-project-automation
bot
moved this from can be merged
to Done
in @Future-Outlier's kuberay project
|
LGTM. |
4 participants
Why are these changes needed?
This PR replaces remaining single-quoted string values in Kubernetes manifests with double quotes to align with the standardized quoting style introduced in #4353. No functional changes.
Related issue number
Closes #4353
Checks