Skip to content

[E2E] [RayCronJob] add e2e test for suspend behavior #4349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndySung320 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[E2E] [RayCronJob] add e2e test for suspend behavior #4349

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5d5eee7
chore(raycronjob): generate client, informer, lister, and apply confi…
AndySung320 Jan 6, 2026
fd62246
test(e2e): add RayCronJob suspend test and enable feature gate in CI
AndySung320 Jan 6, 2026
f22a174
add kubebuilder markers and refine RayCronJob test
AndySung320 Jan 13, 2026
6d1c554
ci: add RayCronJob e2e test to Buildkite pipeline
AndySung320 Jan 13, 2026
ec74032
sync RayCronJob CRDs after kubebuilder marker update
AndySung320 Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .buildkite/values-kuberay-operator-override.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ featureGates:
enabled: true
- name: RayMultiHostIndexing
enabled: true
- name: RayCronJob
enabled: true
2 changes: 2 additions & 0 deletions ray-operator/apis/ray/v1/raycronjob_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ type RayCronJobStatus struct {
//+kubebuilder:printcolumn:name="age",type="date",JSONPath=".metadata.creationTimestamp",priority=0
//+kubebuilder:printcolumn:name="suspend",type=boolean,JSONPath=".spec.suspend",priority=0

// +genclient
Copy link
Contributor

@seanlaii seanlaii Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Maybe we can also add the following annotations as well:

// +kubebuilder:storageversion
// +kubebuilder:resource:categories=all

Copy link
Collaborator

@win5923 win5923 Jan 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • // +kubebuilder:storageversion: marker to indicate the GVK that should be used to store data by the API server.
  • // +kubebuilder:resource:categories=all: Puts the CRD into the all category, so it shows up in kubectl get all.

Ref:
https://book.kubebuilder.io/reference/markers/crd
https://book.kubebuilder.io/reference/generating-crd#multiple-versions

Cool!

Copy link
Contributor Author

@AndySung320 AndySung320 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the suggestion~

//
//nolint:govet // RayCronJob is the Schema for the raycronjobs API
type RayCronJob struct {
metav1.TypeMeta `json:",inline"`
Expand Down
2 changes: 1 addition & 1 deletion ray-operator/config/overlays/test-overrides/deployment-override.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ spec:
containers:
- name: kuberay-operator
args:
- --feature-gates=RayClusterStatusConditions=true,RayJobDeletionPolicy=true,RayMultiHostIndexing=true
- --feature-gates=RayClusterStatusConditions=true,RayJobDeletionPolicy=true,RayMultiHostIndexing=true,RayCronJob=true
226 changes: 226 additions & 0 deletions ray-operator/pkg/client/applyconfiguration/ray/v1/raycronjob.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 41 additions & 0 deletions ray-operator/pkg/client/applyconfiguration/ray/v1/raycronjobspec.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 27 additions & 0 deletions ray-operator/pkg/client/applyconfiguration/ray/v1/raycronjobstatus.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions ray-operator/pkg/client/applyconfiguration/utils.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions ray-operator/pkg/client/clientset/versioned/typed/ray/v1/fake/fake_ray_client.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 33 additions & 0 deletions ray-operator/pkg/client/clientset/versioned/typed/ray/v1/fake/fake_raycronjob.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions ray-operator/pkg/client/clientset/versioned/typed/ray/v1/generated_expansion.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading