Skip to content

Add KuberayTestArch environment variable for architecture override in… #4348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KunWuLuan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add KuberayTestArch environment variable for architecture override in… #4348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ray-operator/test/support/environment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ const (
// KuberayTestRayImage is the Ray image to use for testing.
KuberayTestRayImage = "KUBERAY_TEST_RAY_IMAGE"

KuberayTestArch = "KUBERAY_TEST_ARCH"

KuberayTestUpgradeImage = "KUBERAY_TEST_UPGRADE_IMAGE"
)

Expand All @@ -29,7 +31,11 @@ func GetRayImage() string {
// detect if we are running on arm64 machine, most likely apple silicon
// the os name is not checked as it also possible that it might be linux
// also check if the image does not have the `-aarch64` suffix
if runtime.GOARCH == "arm64" && !strings.HasSuffix(rayImage, "-aarch64") {
arch := runtime.GOARCH
if archFromEnv := lookupEnvOrDefault(KuberayTestArch, ""); archFromEnv != "" {
arch = archFromEnv
}
if arch == "arm64" && !strings.HasSuffix(rayImage, "-aarch64") {
rayImage = rayImage + "-aarch64"
fmt.Printf("Modified Ray Image to: %s for ARM chips\n", rayImage)
}
Expand Down
Loading