generate clientset with 1.35 code-generator #4347
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KunWuLuan <[email protected]>
win5923
reviewed
Jan 6, 2026
ray-operator/hack/update-codegen.sh
Outdated
| SCRIPT_ROOT=$(dirname "${BASH_SOURCE[0]}")/.. | ||
| ROOT_PKG=github.com/ray-project/kuberay/ray-operator | ||
| CODEGEN_PKG=$(go list -m -f "{{.Dir}}" k8s.io/code-generator) | ||
| CODEGEN_PKG=${CODEGEN_PKG:-$(cd "${SCRIPT_ROOT}"; ls -d -1 ./vendor/k8s.io/code-generator 2>/dev/null || echo ../code-generator)} |
Collaborator
There was a problem hiding this comment.
Could you explain the reason for this change?
Contributor
Author
There was a problem hiding this comment.
go vendor is enabled in my environment, and $(go list -m -f "{{.Dir}}" k8s.io/code-generator) return "" when go vendor is enabled. I have rollbacked this change.
Collaborator
There was a problem hiding this comment.
Oh cool, I think we can create an issue for go vendor users.
win5923
reviewed
Jan 6, 2026
Contributor
Author
It seems that the CRD yamls are not updated. I have updated. |
KunWuLuan
force-pushed
the
refector/client-1.35
branch
from
6636ce6 to
7f8fad7
Compare
…esolution Signed-off-by: KunWuLuan <[email protected]>
KunWuLuan
force-pushed
the
refector/client-1.35
branch
from
7f8fad7 to
f201498
Compare
Contributor
Author
|
@win5923 Hi, I think the comments are all solved. Thanks for your comments. Can you review the code again? |
win5923
approved these changes
Jan 7, 2026
Collaborator
|
cc @Future-Outlier and @rueian for the final review! |
CheyuWu
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
to #4345
Checks