-
Notifications
You must be signed in to change notification settings - Fork 683
[history server] move storage interface #4302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[history server] move storage interface #4302
Conversation
Signed-off-by: my-vegetable-has-exploded <[email protected]>
Signed-off-by: my-vegetable-has-exploded <[email protected]>
Future-Outlier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @lorriexingfang to take a look!
Future-Outlier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @JiangJiaWei1103 @machichima need you to help review.
|
Could you also help updating the README?
Thanks! kuberay/historyserver/README.md Lines 118 to 124 in ef4abc4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: my-vegetable-has-exploded <[email protected]>
…storage-interface
done. |
JiangJiaWei1103
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
| - `pkg/`: Core logic for storage backends and collection | ||
| - `pkg/collector/`: Collector-specific code | ||
| - `pkg/storage/`: Storage backend implementations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! The modification is within the scope of this PR.
Just a quick reminder: this documentation doesn’t reflect the current history server code structure (e.g., missing eventserver/). Instead of adding more components on top of outdated docs, I suggest opening a separate issue to update the documentation. Since the history server is still under active development, it may be better to postpone the doc update until we have a first stable version.
Issue link: #4338
Future-Outlier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cursor review
|
cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
machichima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Future-Outlier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
|
Thanks all. |

Why are these changes needed?
Move historyserver/pkg/collector/logcollector/storage to historyserver/pkg/storage and updata imports.
Related issue number
Closes #4278
Checks