[refactor][5/N] Refactor httpproxy_httpclient.go
#4010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: You-Cheng Lin (Owen) <[email protected]>
owenowenisme
changed the title
httpproxy_httpclient.go
owenowenisme
requested review from
kevin85421,
andrewsykim,
rueian and
MortalHappiness
as code owners
rueian
approved these changes
Aug 30, 2025
kevin85421
reviewed
Aug 30, 2025
There was a problem hiding this comment.
Ray Serve also supports gRPC. We should consider renaming it and verify whether KubeRay supports gRPC (#1554)
|
@kevin85421 If so, could you assign #1554 to me? BTW, why would need to rename |
win5923
pushed a commit
to win5923/kuberay
that referenced
this pull request
Sep 4, 2025
Signed-off-by: You-Cheng Lin (Owen) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Similiar to #3992 , removed the ctrl pkg from
httpproxy_httpclient.goRelated issue number
Checks