[apiserver][feat] add pagination to ListRayJobs #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rueian PTAL |
|
I will also open issues to add pagination to |
rueian
reviewed
Apr 8, 2025
|
Others LGTM. The test can be passed locally. |
|
Thanks @rueian ! |
|
cc @dentiny would you mind taking a look? Thanks! |
owenowenisme
changed the title
dentiny
reviewed
Apr 9, 2025
dentiny
reviewed
Apr 9, 2025
|
dentiny
reviewed
Apr 11, 2025
| @@ -505,7 +572,7 @@ func createTestJob(t *testing.T, tCtx *End2EndTestingContext) *api.CreateRayJobR | |||
| configMapName := tCtx.CreateConfigMap(t, map[string]string{ | |||
| "counter_sample.py": ReadFileAsString(t, "resources/counter_sample.py"), | |||
| "fail_fast.py": ReadFileAsString(t, "resources/fail_fast_sample.py"), | |||
| }) | |||
| }, tCtx.currentName) // set the name of the config map to the current name | |||
There was a problem hiding this comment.
Just curious, why do we need this change?
There was a problem hiding this comment.
Initially, I added this because create configmap with same name will get error, but I just changed to the same way that we specify jobname.
for i := 0; i < testJobNum; i++ {
tCtx.currentName = fmt.Sprintf("job%d", i)
tCtx.configMapName = fmt.Sprintf("job%d-cm", i)
testJobs = append(testJobs, createTestJob(t, tCtx))
}
dentiny
approved these changes
Apr 12, 2025
Signed-off-by: You-Cheng Lin <[email protected]>
Signed-off-by: You-Cheng Lin <[email protected]>
Signed-off-by: You-Cheng Lin <[email protected]>
Signed-off-by: You-Cheng Lin <[email protected]>
Signed-off-by: You-Cheng Lin <[email protected]>
Signed-off-by: You-Cheng Lin <[email protected]>
Signed-off-by: You-Cheng Lin <[email protected]>
Signed-off-by: You-Cheng Lin <[email protected]>
Signed-off-by: You-Cheng Lin <[email protected]>
owenowenisme
force-pushed
the
api-server-add-pagination-to-listRayJobs
branch
from
425d9f9 to
7af2743
Compare
kevin85421
approved these changes
Apr 12, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #3269
Why are these changes needed?
Related issue number
Closes #3269
Checks