Add Helm chart unittests for ray-cluster #3277
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Chen <[email protected]>
2 tasks
|
cc @rueian would you mind reviewing this PR? Thanks! |
|
@ChenYi015, thank you for your contribution! Are you on Ray Slack? If you're interested in the community, feel free to DM me on Slack (my handle is "Kai-Hsun Chen (ray team)"). I'd be happy to share more information about the community with you. |
Signed-off-by: Yi Chen <[email protected]>
ChenYi015
force-pushed
the
helm/raycluster-unittest
branch
from
a0a8b43 to
af541f2
Compare
kevin85421
reviewed
Apr 14, 2025
There was a problem hiding this comment.
Hi @ChenYi015, this PR overall looks good to me, but it's too big so that I may miss something. Would you mind splitting it into smaller PRs? For example,
- 1 PR to update
{{- if .Values.head.rayVersion }}to{{- with .Values.head.rayVersion }}. - 1 PR to update
indenttonindent(btw, is there any linter for this?) - 1 PR to add tests
Sure, I will split it into smaller ones. |
This was referenced Apr 15, 2025
|
Close this PR for it has already been split into smaller ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Make sure ray-cluster Helm chart can work as expected with various configurations by adding unit tests.
One can run Helm chart unit tests by:
$ helm plugin install https://github.com/helm-unittest/helm-unittest.git $ helm unittest helm-chart/ray-cluster --strict --debug ### Chart [ ray-cluster ] helm-chart/ray-cluster PASS Test RayCluster helm-chart/ray-cluster/tests/raycluster_test.yaml Charts: 1 passed, 1 total Test Suites: 1 passed, 1 total Tests: 96 passed, 96 total Snapshot: 0 passed, 0 total Time: 281.1805msRelated issue number
Checks