fix: user lists cache - [CU-869bgh32v]

src/__tests__/hooks/profile/useBlockMutation.test.tsx

@@ -264,10 +264,6 @@ describe('useBlockMutation', () => {
     expect(invalidateSpy).toHaveBeenCalledWith(
       expect.objectContaining({ queryKey: ['following', 'viewer'] })
     );
-
-    expect(invalidateSpy).toHaveBeenCalledWith(
-      expect.objectContaining({ queryKey: ['following-feed', 'viewer'], exact: true })
-    );
   });
 
   it('does not call updateConnectionsLists when block === previous (change === 0)', async () => {

src/__tests__/hooks/profile/useFollowMutation.test.tsx

@@ -34,6 +34,12 @@ const mockUseUserStore = useUserStore as jest.MockedFunction<typeof useUserStore
 };
 mockUseUserStore.getState = jest.fn();
 
+jest.mock('@/services/connections', () => ({
+  followUser: jest.fn(),
+  unfollowUser: jest.fn(),
+  getUserProfile: jest.fn(),
+}));
+
 const rel: UserProfile['relationship'] = {
   blocking: false,
   blockedBy: false,
@@ -534,27 +540,6 @@ describe('useFollowMutation', () => {
     expect(revertedRetweeters.pages[0].data[0].relationship?.following).toBe(false);
   });
 
-  it('handles mutation without target profile in cache', async () => {
-    const queryClient = createQueryClient();
-    const wrapper = createWrapper(queryClient);
-
-    const mockUpdateUser = jest.fn();
-    const viewerProfile = createProfile({ username: 'viewer', followingCount: 5 });
-    setUserStoreState({ user: viewerProfile, updateUser: mockUpdateUser });
-
-    mockFollowUser.mockResolvedValue({ success: true });
-
-    const { result } = renderHook(() => useFollowMutation(), { wrapper });
-
-    await act(async () => {
-      await result.current.mutateAsync({ username: 'unknownUser', follow: true, previous: false });
-    });
-
-    expect(mockUpdateUser).toHaveBeenCalledWith({ followingCount: 6 });
-
-    expect(queryClient.getQueryData(['profile', 'unknownUser'])).toBeUndefined();
-  });
-
   it('handles unfollow mutation correctly with cache updates', async () => {
     const { unfollowUser } = jest.requireMock('@/services/connections');
     const queryClient = createQueryClient();

src/__tests__/hooks/profile/useMuteMutation.test.tsx

@@ -285,8 +285,5 @@ describe('useMuteMutation', () => {
     expect(invalidateSpy).toHaveBeenCalledWith(
       expect.objectContaining({ queryKey: ['profile', 'target'] })
     );
-    expect(invalidateSpy).toHaveBeenCalledWith(
-      expect.objectContaining({ queryKey: ['following-feed', 'viewer'], exact: true })
-    );
   });
 });

src/__tests__/profile/FollowingScreen.test.tsx

@@ -17,6 +17,14 @@ jest.mock('@/services/connections', () => ({
   getUserFollowing: jest.fn(),
 }));
 
+jest.mock('@react-navigation/native', () => {
+  const actualNav = jest.requireActual('@react-navigation/native');
+  return {
+    ...actualNav,
+    useFocusEffect: jest.fn().mockImplementation((callback) => callback()),
+  };
+});
+
 const mockQueryClient = new QueryClient({
   defaultOptions: {
     queries: { retry: false },

src/__tests__/screens/settings/privacy/BlockedAccountsScreen.test.tsx

@@ -13,6 +13,14 @@ import { navigationRef } from '@/navigation/navigationRef';
 import BlockedAccountsScreen from '@/screens/settings/privacy/BlockedAccountsScreen';
 import { PROFILE, ROOT } from '@/utils/navigation/routeNames';
 
+jest.mock('@react-navigation/native', () => {
+  const actualNav = jest.requireActual('@react-navigation/native');
+  return {
+    ...actualNav,
+    useFocusEffect: jest.fn().mockImplementation((callback) => callback()),
+  };
+});
+
 jest.mock('@/hooks/profile/useUserBlocks', () => ({ useUserBlocks: jest.fn() }));
 jest.mock('@/hooks/profile/useBlockMutation', () => ({ useBlockMutation: jest.fn() }));
 jest.mock('@/hooks/profile/useFollowMutation', () => ({ useFollowMutation: jest.fn() }));

src/__tests__/screens/settings/privacy/MutedAccountsScreen.test.tsx

@@ -13,6 +13,13 @@ import { navigationRef } from '@/navigation/navigationRef';
 import MutedAccountsScreen from '@/screens/settings/privacy/MutedAccountsScreen';
 import { PROFILE, ROOT } from '@/utils/navigation/routeNames';
 
+jest.mock('@react-navigation/native', () => {
+  const actualNav = jest.requireActual('@react-navigation/native');
+  return {
+    ...actualNav,
+    useFocusEffect: jest.fn().mockImplementation((callback) => callback()),
+  };
+});
 jest.mock('@/hooks/profile/useUserMutes', () => ({ useUserMutes: jest.fn() }));
 jest.mock('@/hooks/profile/useBlockMutation', () => ({ useBlockMutation: jest.fn() }));
 jest.mock('@/hooks/profile/useFollowMutation', () => ({ useFollowMutation: jest.fn() }));
@@ -32,8 +39,9 @@ const setPlatformOS = (os: typeof _initialOS) => {
 };
 
 describe('MutedAccountsScreen', () => {
+  const queryClient = new QueryClient();
+
   const renderWithClient = (ui: ReactElement) => {
-    const queryClient = new QueryClient();
     return render(ui, {
       wrapper: ({ children }) => (
         <QueryClientProvider client={queryClient}>{children}</QueryClientProvider>
@@ -42,6 +50,7 @@ describe('MutedAccountsScreen', () => {
   };
 
   beforeEach(() => {
+    queryClient.clear();
     jest.clearAllMocks();
 
     (useTheme as jest.Mock).mockReturnValue({ theme: 'light' });

src/components/ui/TimelineFeedList.tsx

@@ -90,7 +90,8 @@ export const MemoizedTweetItem = memo<{
       a.retweetCount === b.retweetCount &&
       a.replyCount === b.replyCount &&
       (a.media?.length || 0) === (b.media?.length || 0) &&
-      !!a.quotedTweet === !!b.quotedTweet
+      !!a.quotedTweet === !!b.quotedTweet &&
+      a.author.relationship === b.author.relationship
     );
   }
 );

src/components/ui/TweetDrawer.tsx

@@ -1,4 +1,4 @@
-import { useCallback, useMemo } from 'react';
+import { useCallback, useMemo, useState } from 'react';
 
 import { Alert, StyleSheet, Text, TouchableOpacity, View } from 'react-native';
 
@@ -36,6 +36,8 @@ const TweetDrawer = ({ visible, onClose, author, onShowDeleteModal }: TweetDrawe
   const isMuted = author.relationship?.muted ?? false;
   const isFollowing = author.relationship?.following ?? false;
 
+  const [followingState, setFollowingState] = useState<boolean>(isFollowing);
+
   const followMutation = useFollowMutation();
   const blockMutation = useBlockMutation();
   const muteMutation = useMuteMutation();
@@ -63,6 +65,9 @@ const TweetDrawer = ({ visible, onClose, author, onShowDeleteModal }: TweetDrawe
           onError: (error) => {
             Alert.alert('Unable to update follow', error?.message ?? 'Please try again.');
           },
+          onSuccess: () => {
+            setFollowingState(shouldFollow);
+          },
         }
       );
     },
@@ -159,13 +164,13 @@ const TweetDrawer = ({ visible, onClose, author, onShowDeleteModal }: TweetDrawe
                 testID="follow-button"
               >
                 <MaterialCommunityIcons
-                  name={isFollowing ? 'account-remove-outline' : 'account-plus-outline'}
+                  name={followingState ? 'account-remove-outline' : 'account-plus-outline'}
                   size={25}
                   color={currentColors.mutedForeground}
                 />
                 <AppText>
                   <Text>
-                    {isFollowing ? `Unfollow @${author.username}` : `Follow @${author.username}`}
+                    {followingState ? `Unfollow @${author.username}` : `Follow @${author.username}`}
                   </Text>
                 </AppText>
               </TouchableOpacity>