Skip to content

Conversation

@toolmantim
Copy link
Contributor

It appears that the reCAPTCHA support added in #311 ignored the badge/iframe version of slackin, and as it stands at the moment the badge version is unusable (see #311 (comment)). This is a problem for people wanting to update their Heroku apps because of the Node vulnerability.

This is a start at fixing it, but I'm not exactly sure how we can even support it in an iframe popup? For example:

hrmm

  • Get recaptcha showing in the iframe version
  • Figure out what to do

@toolmantim
Copy link
Contributor Author

toolmantim commented Aug 7, 2017

@whit537 for now I've had to switch to a fork/branch that reverts #311: https://github.com/toolmantim/slackin/commits/revert-recaptcha

@chadwhitacre
Copy link
Contributor

chadwhitacre commented Aug 8, 2017

@toolmantim FYI I'm not a maintainer on this project and I don't plan to help with adding reCAPTCHA support to the badge version. See SlackOut for an explanation of the security risk you're taking by reverting #311 (we're not actually using SlackIn anymore because our Slack hasn't recovered from SlackOut yet). Good luck! :-)

@toolmantim
Copy link
Contributor Author

@whit537 yep, understood. I just thought you might have some ideas/thoughts on how to unbreak things, seeing as you did the implementation?

My only suggestion is to remove the popup that opens when you click the badge, and instead link to the URL in a new tab/window.

@chadwhitacre
Copy link
Contributor

seeing as you did the implementation?

I actually just cleaned up someone else's implementation. 😞

@emedvedev emedvedev mentioned this pull request Oct 30, 2017
@toolmantim
Copy link
Contributor Author

Having switched to slackin-extended, I'm closing this for now.

@toolmantim toolmantim closed this Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants