Skip to content

Conversation

@avatsaev
Copy link

@avatsaev avatsaev commented Sep 7, 2016

Added Google recaptcha to discourage spammers from screwing with invite limits
Fixed deployment error on heroku (dist not found) by removed dist folder from gitignore

@jackmcdade
Copy link

Would love to see this merged.

@bmgdev
Copy link

bmgdev commented Sep 14, 2016

+1

julianschiavo
julianschiavo approved these changes Oct 20, 2016
@jackmcdade
Copy link

I've been using this fork for a few weeks now but it has recently just broken. The ReCaptcha's fail every time. I wouldn't merge this without resolving the issue.

@jackmcdade
Copy link

@jaspergreenham If I knew i would fix it.

@jackmcdade
Copy link

@jaspergreenham No, @avatsaev did.

@jackmcdade
Copy link

jackmcdade commented Oct 20, 2016

@jaspergreenham It's a bit late to expect much response so quickly on a fork of a niche app. I recommend a little patience :)

@jackmcdade
Copy link

@jaspergreenham you're gonna recommend something else even after pinging @avatsaev in the middle of the night, and him fixing it within 8 hours?

I for one, am very grateful. Thanks @avatsaev!!

@avatsaev
Copy link
Author

you're welcome

@julianschiavo
Copy link

I've asked @rauchg to merge, he asked for link, I gave, now waiting to hear back :).

@rauchg
Copy link
Owner

rauchg commented Oct 22, 2016

Thanks @jaspergreenham. The PR is not mergeable. I also don't have any screenshots or anything else to ascertain what this looks like, therefore making it difficult to merge :|

@jackmcdade
Copy link

We're using it on slack.statamic.com. You can check it out there.

On Oct 22, 2016, at 6:06 PM, Guillermo Rauch [email protected] wrote:

Thanks @jaspergreenham. The PR is not mergeable. I also don't have any screenshots or anything else to ascertain what this looks like, therefore making it difficult to merge :|


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@passsy
Copy link

passsy commented Nov 4, 2016

Thanks!

@rauchg
Copy link
Owner

rauchg commented Nov 26, 2016

@jackmcdade I'd like to only display it after pressing "get my invite". I'll adjust the PR myself

@lucymhdavies
Copy link

@rauchg any news on getting this PR updated and merged?

@chadwhitacre
Copy link
Contributor

chadwhitacre commented May 25, 2017

I also don't have any screenshots or anything else to ascertain what this looks like


screen shot 2017-05-25 at 4 58 49 pm


screen shot 2017-05-25 at 4 59 06 pm


screen shot 2017-05-25 at 4 59 19 pm

@chadwhitacre
Copy link
Contributor

The PR is not mergeable.

GitHub sez unknown repo. Is this PR orphaned? @avatsaev Can you make a new PR? Or update this one?

@rauchg
Copy link
Owner

rauchg commented May 26, 2017

@whit537

It has merge conflicts:

.gitignore
README.md
bin/slackin

@chadwhitacre
Copy link
Contributor

I recommend closing in favor of #311.

@avatsaev avatsaev closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants