Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Web Server #328

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

Balferian
Copy link
Contributor

@Balferian Balferian commented Sep 19, 2022

Fixes #315 .

Changes proposed in this Pull Request:

  • Allowed to use external db for web server for guild icons.
  • Usage of "EmblemUseWebservice" was removed from modules.
  • Added support for gif with transparent layer.
  • Find the way to convert rgb(255, 0, 255) mask to transparent layer for animated GIF emblem.
gif_icons.mp4

@ecdarreola
Copy link

Transparent gif with rgb(255, 0, 255) as some fill are displaying as is? Is this intended?

@mazvi
Copy link
Contributor

mazvi commented Nov 8, 2022

please merge this to master

@Balferian
Copy link
Contributor Author

please merge this to master

@mazvi It`s not completed yet.

@Daegaladh
Copy link
Member

The only way to change the magenta background into transparent and keep the animation I can think of is using imagemagick

@mazvi
Copy link
Contributor

mazvi commented Nov 8, 2022

We don't have to worry about transparency :) no problem not being transparent on the website :D

@Balferian
Copy link
Contributor Author

The only way to change the magenta background into transparent and keep the animation I can think of is using imagemagick

imagick package is not included by default in php, users may experience problems because of this (not all hosts allow to install packages for php), so I don't want to use imagemagick now.
If there is no other way to process GIFs, then we will return to this option (imagemagick) and make it optional.

@Daegaladh
Copy link
Member

Daegaladh commented Nov 9, 2022

Well, php-gd is also an extension and we use it anyway

Maybe you could check for imagemagick and made it optional to show transparency depending on if it's installed or not

@Pokye
Copy link

Pokye commented Nov 2, 2023

Any prediction on when this PR will merge? xD

@mazvi
Copy link
Contributor

mazvi commented Nov 9, 2023

Any prediction on when this PR will merge? xD

My prediction is February 2024

Added configs for webserver.
"EmblemUseWebservice" was removed from modules.
@sanasol sanasol force-pushed the guild_icons_update branch from fe91d48 to b3b8ead Compare November 9, 2023 22:38
@sanasol sanasol merged commit a2a068a into rathena:master Nov 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need Update to support rA Initial support for web service
6 participants