Move pretty_assertions to dev-dependencies #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that ratatui consumers don't pull in pretty_assertions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 89.72% 89.72%
=======================================
Files 4 4
Lines 613 613
=======================================
Hits 550 550
Misses 63 63 ☔ View full report in Codecov by Sentry. |
Merged
|
Thanks. It may be some time until the next Ratatui release comes out (as it's bigger one due to the refactoring into several crates). I'm assuming this is probably not a blocker...? |
joshka
pushed a commit
that referenced
this pull request
Jan 4, 2025
## 🤖 New release * `instability-example`: 0.3.5 -> 0.3.6 * `instability`: 0.3.5 -> 0.3.6 <details><summary><i><b>Changelog</b></i></summary><p> ## `instability-example` <blockquote> ## [0.3.5](instability-example-v0.3.4...instability-example-v0.3.5) - 2024-12-21 ### Added - Allow marking impl blocks unstable/stable (#15) - add stable macro (#14) - use doc(cfg) - allow use statements to be marked unstable (#3) ### Other - prepare instability-example for publish (#18) - bump msrv to 1.63 - tweak doc wording and formatting (#4) - fork and change name to instabilty - Apply visibility restriction to struct fields ([#10](#10)) - Update to Rust edition 2021 ([#9](#9)) - Add issue tracking - Initial version </blockquote> ## `instability` <blockquote> ## [0.3.6](instability-v0.3.5...instability-v0.3.6) - 2025-01-04 ### Other - Move pretty_assertions to dev-dependencies ([#19](#19)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Yeah no need for a ratatui bump yet, thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that ratatui consumers don't pull in pretty_assertions