Skip to content

Update hellbender_2350A_devboard.h for release version of the board. #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

CBJamo
Copy link
Contributor

@CBJamo CBJamo commented Apr 25, 2025

We've only used the old version of this board internally so there's no reason to maintain both versions.

Fixes #2440

@lurch lurch self-assigned this Apr 26, 2025
@lurch
Copy link
Contributor

lurch commented Apr 26, 2025

Can you rebase this onto the latest version of develop please? Note that (after #2397) // pico_cmake_set PICO_PLATFORM=rp2350 has now become pico_board_cmake_set(PICO_PLATFORM, rp2350) https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/hellbender_2350A_devboard.h#L15
(as well as // pico_cmake_set_default name = value changing to pico_board_cmake_set_default(name, value)).

EDIT: In #2442 I've updated tools/check_board_header.py to display better error messages.

@lurch
Copy link
Contributor

lurch commented Apr 26, 2025

...and if I make those changes locally, tools/check_board_header.py complains with:
Exception: src/boards/include/boards/hellbender_2350A_devboard.h:81 PICO_DEFAULT_SPI_CSN_PIN is set to 28 which isn't a valid pin for CSN on SPI 0
and Table 3 in https://datasheets.raspberrypi.com/rp2350/rp2350-datasheet.pdf indeed shows that GPIO28 has SPI function SPI1 RX.

@CBJamo
Copy link
Contributor Author

CBJamo commented Apr 28, 2025

Rebased, sorry about missing that.

I removed the default cs pin define, the bus is connected to both an expansion header and a micro sd card.

Copy link
Contributor

@lurch lurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants