-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add board header for Waveshare RP2350-USB-A #2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sonodima
wants to merge
2
commits into
raspberrypi:develop
Choose a base branch
from
sonodima:waveshare_rp2350_usb_a
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
/* | ||
* Copyright (c) 2020 Raspberry Pi (Trading) Ltd. | ||
* | ||
* SPDX-License-Identifier: BSD-3-Clause | ||
*/ | ||
|
||
// ----------------------------------------------------- | ||
// NOTE: THIS HEADER IS ALSO INCLUDED BY ASSEMBLER SO | ||
// SHOULD ONLY CONSIST OF PREPROCESSOR DIRECTIVES | ||
// ----------------------------------------------------- | ||
|
||
#ifndef _BOARDS_WAVESHARE_RP2350_USB_A_H | ||
#define _BOARDS_WAVESHARE_RP2350_USB_A_H | ||
|
||
pico_board_cmake_set(PICO_PLATFORM, rp2350) | ||
|
||
// For board detection | ||
#define WAVESHARE_RP2350_USB_A | ||
|
||
// On some samples, the xosc can take longer to stabilize than is usual | ||
#ifndef PICO_XOSC_STARTUP_DELAY_MULTIPLIER | ||
#define PICO_XOSC_STARTUP_DELAY_MULTIPLIER 64 | ||
#endif | ||
|
||
// --- RP2350 VARIANT --- | ||
#define PICO_RP2350A 1 | ||
|
||
// --- UART --- | ||
#ifndef PICO_DEFAULT_UART | ||
#define PICO_DEFAULT_UART 0 | ||
#endif | ||
#ifndef PICO_DEFAULT_UART_TX_PIN | ||
#define PICO_DEFAULT_UART_TX_PIN 0 | ||
#endif | ||
#ifndef PICO_DEFAULT_UART_RX_PIN | ||
#define PICO_DEFAULT_UART_RX_PIN 1 | ||
#endif | ||
|
||
// --- WS2812 --- | ||
#ifndef PICO_DEFAULT_WS2812_PIN | ||
#define PICO_DEFAULT_WS2812_PIN 16 | ||
#endif | ||
|
||
// --- I2C --- | ||
#ifndef PICO_DEFAULT_I2C | ||
#define PICO_DEFAULT_I2C 1 | ||
#endif | ||
#ifndef PICO_DEFAULT_I2C_SDA_PIN | ||
#define PICO_DEFAULT_I2C_SDA_PIN 6 | ||
#endif | ||
#ifndef PICO_DEFAULT_I2C_SCL_PIN | ||
#define PICO_DEFAULT_I2C_SCL_PIN 7 | ||
#endif | ||
|
||
// --- SPI --- | ||
#ifndef PICO_DEFAULT_SPI | ||
#define PICO_DEFAULT_SPI 0 | ||
#endif | ||
#ifndef PICO_DEFAULT_SPI_SCK_PIN | ||
#define PICO_DEFAULT_SPI_SCK_PIN 2 | ||
#endif | ||
#ifndef PICO_DEFAULT_SPI_TX_PIN | ||
#define PICO_DEFAULT_SPI_TX_PIN 3 | ||
#endif | ||
#ifndef PICO_DEFAULT_SPI_RX_PIN | ||
#define PICO_DEFAULT_SPI_RX_PIN 4 | ||
#endif | ||
#ifndef PICO_DEFAULT_SPI_CSN_PIN | ||
#define PICO_DEFAULT_SPI_CSN_PIN 5 | ||
#endif | ||
|
||
// --- PIO USB --- | ||
#ifndef PICO_DEFAULT_PIO_USB_DP_PIN | ||
#define PICO_DEFAULT_PIO_USB_DP_PIN 12 | ||
#endif | ||
|
||
// --- FLASH --- | ||
#define PICO_BOOT_STAGE2_CHOOSE_W25Q080 1 | ||
|
||
#ifndef PICO_FLASH_SPI_CLKDIV | ||
#define PICO_FLASH_SPI_CLKDIV 3 | ||
#endif | ||
|
||
pico_board_cmake_set_default(PICO_FLASH_SIZE_BYTES, (2 * 1024 * 1024)) | ||
#ifndef PICO_FLASH_SIZE_BYTES | ||
#define PICO_FLASH_SIZE_BYTES (2 * 1024 * 1024) | ||
#endif | ||
|
||
// Drive high to force power supply into PWM mode (lower ripple on 3V3 at light loads) | ||
#define PICO_SMPS_MODE_PIN 23 | ||
|
||
pico_board_cmake_set_default(PICO_RP2350_A2_SUPPORTED, 1) | ||
#ifndef PICO_RP2350_A2_SUPPORTED | ||
#define PICO_RP2350_A2_SUPPORTED 1 | ||
#endif | ||
|
||
#endif |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no SDK support for this, so IMHO prefixing it with
PICO_DEFAULT_
is a bit misleading. PerhapsWAVESHARE_RP2350_USB_A_USB_DP_PIN
would be better?Also, if you're defining the
USB_DP_PIN
, would it make sense to also define theUSB_DM_PIN
??EDIT: I also just removed the
PIO
from my suggested define-name, because thePIO
part is a software-detail, and IMHO the board-headers in the SDK should just describe the raw hardware.