Repository navigation
Conversation
Add a cross-parent reference and four same-parent reproducers for commands affecting nodes taken by another inserter. Co-Authored-By: Codex GPT-6 Astra <codex@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreates the original PR #212, which was automatically closed when my fork was accidentally deleted.
Adds reproducers for
children.command <--targeting a node that another inserter has taken.Current behavior:
RemoveandReplaceleave the stolen node untouched.Removedeletes the stolen node andReplacereplaces it in the destination’s region.Expected behavior:
Both commands should leave nodes outside their own region untouched, consistent with the existing cross-parent tests in
ChildrenCommandReceiverSpec.Tests only; no implementation changes. Against master, the cross-parent reference passes and four same-parent cases fail.
Run:
sbt 'testOnly *ChildrenCommandStolenNodeSpec'