Repository navigation
Conversation
Add two reference tests and three reproducers for same-parent group reclamation after removal and plain placement. Co-Authored-By: Codex GPT-6 Astra <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds reproducers for a dynamic inserter reclaimed by a list after another list removes it and
parent.amend(inserter)recreates it under the same parent.Current behavior:
The reclaimed group lacks its trailing sentinel. After the enclosing list takes the group's child as a separate item, updating the group removes that child, and moving the group carries it into another list.
Expected behavior:
The child should remain with the enclosing list, consistent with existing stealing and group-move behavior.
Tests only; no implementation changes. Against master, two reference tests pass and three reproducers fail.
Run:
sbt 'testOnly *NestedGroupReStealSpec'