Repository navigation
Test: reproduce unnecessary remount of a retained nested child - #213
Merged
raquo merged 3 commits intoSep 24, 2026
Merged
Conversation
Add a takeover reproducer that retains the same child previously rendered through a nested inserter. Co-Authored-By: Codex GPT-6 Astra <codex@openai.com>
…s minimizeDiff option. #213 This eliminates unnecessary re-mounts in more complicated cases.
Owner
|
Thanks, I've extended As part of this I've also added a new |
raquo
added a commit
that referenced
this pull request
Sep 24, 2026
…s minimizeDiff option. #213 This eliminates unnecessary re-mounts in more complicated cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a reproducer for an
onMountInserttakeover fromchildren <--containingaand nestedchild <-- Val(b)tochild <-- b.Current behavior:
The takeover unmounts
a, unmountsb, then mountsbagain.Expected behavior:
Only
ashould unmount. The samebis already mounted under the same DOM parent and should be retained, matching the existing non-nested takeover test and the cleanup helper’s retention contract.Tests only; no implementation changes. Against master, the existing 13 takeover tests pass and the new reproducer fails.
Run:
sbt 'testOnly *InserterTakeoverSpec'