Repository navigation
Conversation
nguyenyou
force-pushed
the
claude/nested-group-activation-order
branch
from
September 22, 2026 10:33
c1c1d6e to
3f8c942
Compare
Adds regression tests for stale content mounting after a nested group move. Co-Authored-By: Codex GPT-6 Astra <codex@openai.com>
… group move When a moved group's stale content mounts ahead of the group's re-render, its own bindings run too. Here the stale element's `child.maybe <--` steals a node from an unrelated live list; the group then drops the stale element, taking that node with it for good. Covers all three move paths, plus depth 2, where the stale content is a nested group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add two reference tests and three reproducers for same-parent group reclamation after removal and plain placement. Co-Authored-By: Codex GPT-6 Astra <codex@openai.com>
raquo
force-pushed
the
claude/nested-group-activation-order
branch
from
September 24, 2026 11:53
0c537e6 to
be54d9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds regression tests for
NestedGroup.moveToParent.A
child <--inserter retains its DOM content while unmounted and must reconcile to the latest value on remount. The old node must not receive a mount callback after it has been superseded.Current behavior mounts the stale node first, then creates and mounts the new node.
Expected behavior is to unmount the old node, create the new node, and mount only the new node.
The stale mount can cause permanent damage
Mounting stale content also runs its own bindings. In the second set of tests, the stale element has a
child.maybe <--that claims an elementeliving in an unrelated live list:efrom that list.eleaves the page with it.eis never restored. The actual events are[mount:c, unmount:c, unmount:e], where nothing should happen.The same scenario without a move (the REFERENCE tests) leaves
euntouched.This fails on all three move paths:
It also fails at depth 2, where the stale content is a nested group (actual:
[unmount:e]). The recursive move re-registers the inner group too, so a fix must hold at every nesting depth, not just for the outermost group.Run:
sbt 'testOnly *NestedGroupActivationOrderSpec'