Repository navigation
Perf: avoid parent-wide scans for command insertion - #208
Merged
Merged
Conversation
Walk within the command span and count toward zero to handle Int.MinValue safely. Add populated and empty span regression tests. Co-Authored-By: Codex GPT-6 Astra <codex@openai.com>
Owner
|
Thanks, good efficiency 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CollectionCommand.Insertcurrently searches the parent’s children to locate both span boundaries. Walk directly from the start or end sentinel instead, limiting traversal toO(min(abs(index), span size)), independent of unrelated siblings.Preserve negative indexing and boundary clamping. Count toward zero to handle
Int.MinValuewithout overflow, and report the out-of-range distance and clamped boundary.Add regression tests for
Int.MinValueon populated and empty spans.Validation: all 10
ChildrenCommandReceiverSpectests pass under Node.js;git diff --checkpasses.