Repository navigation
[WIP] Migrate to sbt 2.x - #191
Draft
tanishiking wants to merge 2 commits into
Draft
tanishiking wants to merge 2 commits into
tanishiking wants to merge 2 commits into
Conversation
scalajs-bundler is a bit deprecated, and not maintained recently. Use the official `@scala-js/vite-plugin-scalajs` instead to bundle Scala.js output with npm dependencies into a single IIFE bundle for mdoc.
Prepare for sbt 2.x depends on - scala-js/scala-js#5314 - scala-js/scala-js-env-jsdom-nodejs#63 Context, this is kinda experiment to verify scalajs plugin in sbt2 works fine in downstream projects (it seems working good!), if you feel like it's too early to move to sbt2, please ignore this PR until the right time ;)
24 tasks done
Owner
|
Thanks! I would like to migrate to sbt v2 when its final release drops (maybe a couple patches later actually), but feel free to keep this draft PR open in the meantime. Getting rid of scalajs-bundler is a good move too, I already started on that in my other projects, but in Laminar it's a bit more involved, so thanks for working through that. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
Context: this is kinda experiment to verify scalajs plugin with sbt2 works fine in downstream projects (it seems working good!), if you feel like it's too early to move to sbt2, please ignore this PR (or close for now, I'm willing to open the new one when it's really ready ;)