Misiug/script testing #124
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misiugodfrey
requested review from
Avinash-Raj,
mattgara,
paul-aiyedun and
simoneves
misiugodfrey
commented
Nov 5, 2025
| echo "Error: PRESTO_DATA_DIR must be set to the directory path that contains the benchmark data directories" | ||
| print_help | ||
| exit 1 | ||
| echo_error "Error: PRESTO_DATA_DIR must be set to the directory path that contains the benchmark data directories" |
Contributor
Author
There was a problem hiding this comment.
An earlier version of these tests was relying on errors being reported to stderr to avoid displaying stdout. I would like to proliferate these kinds of changes, but will leave it here until tests to through.
| # limitations under the License. | ||
|
|
||
| # --- Print error messages in red --- | ||
| function echo_error() { |
Contributor
Author
There was a problem hiding this comment.
This is the kind of common code outlining I would like to do on a larger scale, but would like the tests in place before committing to larger changes.
Contributor
|
This is a bit of a leap for my brain. I'll look again when I'm fresh. TIL: |
Contributor
Author
|
@coderabbitai review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimented with adding some script testing with pytest and bats to make changing our scripts easier, as I would like to enable some larger-scale refactors. Would welcome feedback on if we should take this direction further.
This specifically aims to test the scripts that are not tested by the current CI (datagen, schema-setup, etc...).
Not sure if we want to add a dependency on bats (needed to run the script testing) or just leave that up to users.