Presto: Separate Hive configs for Coordinator & Worker #121
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1 @@ | ||
| # This file will be overridden by a coordinator or worker specific configuration file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Select the connector implementation. "hive-hadoop2" uses the Hive connector | ||
| # backed by Hadoop 2.x libraries which is the default for Presto's Hive support. | ||
| connector.name=hive-hadoop2 | ||
|
|
||
| # Configure the metastore implementation. "file" enables a simple file-based | ||
| # metastore suitable for local testing without an external Hive Metastore (HMS). | ||
| # See https://prestodb.io/docs/current/installation/deployment.html#configuring-a-file-based-metastore for more details. | ||
| hive.metastore=file | ||
| # Root directory where the file-based metastore stores table and partition | ||
| # metadata. This path is inside the container volume so state persists across | ||
| # server restarts during tests. | ||
| hive.metastore.catalog.dir=file:/var/lib/presto/data/hive/metastore | ||
| # Allow DROP TABLE statements. Enabled to make smoke/perf tests able to reset | ||
| # state and clean up artifacts without manual intervention. | ||
| hive.allow-drop-table=true | ||
|
|
||
| # Control whether Presto can split files for parallel reads. Disable when the | ||
| # file compression/format isn't splittable to avoid read failures. TPCH Parquet | ||
| # test data commonly uses SNAPPY compression that isn't splittable at the file | ||
| # level here, hence this must be false. | ||
| hive.file-splittable=false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Select the connector implementation. "hive-hadoop2" uses the Hive connector | ||
| # backed by Hadoop 2.x libraries which is the default for Presto's Hive support. | ||
| connector.name=hive-hadoop2 | ||
|
|
||
| # Configure the metastore implementation. "file" enables a simple file-based | ||
| # metastore suitable for local testing without an external Hive Metastore (HMS). | ||
| # See https://prestodb.io/docs/current/installation/deployment.html#configuring-a-file-based-metastore for more details. | ||
| hive.metastore=file | ||
| # Root directory where the file-based metastore stores table and partition | ||
| # metadata. This path is inside the container volume so state persists across | ||
| # server restarts during tests. | ||
| hive.metastore.catalog.dir=file:/var/lib/presto/data/hive/metastore | ||
| # Allow DROP TABLE statements. Enabled to make smoke/perf tests able to reset | ||
| # state and clean up artifacts without manual intervention. | ||
| hive.allow-drop-table=true | ||
|
|
||
| # Control whether Presto can split files for parallel reads. Disable when the | ||
| # file compression/format isn't splittable to avoid read failures. TPCH Parquet | ||
| # test data commonly uses SNAPPY compression that isn't splittable at the file | ||
| # level here, hence this must be false. | ||
| hive.file-splittable=false | ||
|
|
||
| # Parquet read options | ||
| parquet.reader.chunk-read-limit=0 | ||
| parquet.reader.pass-read-limit=0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These configurations do not appear in the documentation. Can you please add comments that describe what these parameters do and why they are needed?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They aren't needed, other than to prove a point that the Coordinator and Worker configs can be different, but apparently @devavret tweaks them on his local laptop system, so asked for them to be exposed.
The values are not documented in Velox itself, but appear to be passed to the cuDF Chunked Parquet Reader, and that documentation is here:
https://docs.rapids.ai/api/libcudf/stable/classcudf_1_1io_1_1chunked__parquet__reader#a49f5549b53257828d50f5fa65114e07a
The values in that API are in bytes, but it appears that the config parser is smart enough to convert (say) 16M into (16 * 1024 * 1024).
I have added comments to the template file based on the parameter descriptions in that documentation.