Skip to content

Pass GitHub token to style checks#589

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
bdice:pass-gh-token-to-check-style
Jul 7, 2026
Merged

Pass GitHub token to style checks#589
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
bdice:pass-gh-token-to-check-style

Conversation

@bdice

@bdice bdice commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

This exposes the GitHub Actions token to ci/check_style.sh as GH_TOKEN. The style-check job already receives a repository-scoped token with contents: read, but the failing step did not have it in its environment, so rapids-metadata made an unauthenticated request and hit HTTP 429. Passing the token follows GitHub's supported authentication pattern and enables the companion rapidsai/rapids-metadata#79 change to make authenticated requests with retries. rapidsai/rapids-metadata#79 depends on this PR.

@bdice bdice added bug Something isn't working non-breaking Introduces a non-breaking change labels Jul 6, 2026
@bdice bdice marked this pull request as ready for review July 6, 2026 23:01
@bdice bdice requested a review from a team as a code owner July 6, 2026 23:01
@bdice bdice requested review from jameslamb and removed request for a team July 6, 2026 23:01
@gforsyth gforsyth removed the request for review from jameslamb July 7, 2026 14:48
@gforsyth

gforsyth commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@gforsyth

gforsyth commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot rapids-bot Bot merged commit 60f3b1c into rapidsai:main Jul 7, 2026
2 checks passed
@gforsyth

gforsyth commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Succeeded on a re-run after merging this PR. Not saying this PR necessarily fixed things, because the error is transient, but it certainly didn't break anything: https://github.com/rapidsai/kvikio/actions/runs/28892292204/job/85709890287?pr=1000

rapids-bot Bot pushed a commit to rapidsai/rapids-metadata that referenced this pull request Jul 7, 2026
This updates remote metadata fetching to use the GitHub Contents API with `GH_TOKEN` or `GITHUB_TOKEN` when available, while retaining the raw URL for unauthenticated requests. It adds bounded retries for rate limits and transient HTTP or transport errors, honoring GitHub’s `Retry-After` header when provided. This addresses the cuDF style-check failure where an unauthenticated metadata request returned HTTP 429. It depends on [rapidsai/shared-workflows#589](rapidsai/shared-workflows#589) to expose `${{ github.token }}` as `GH_TOKEN` to style-check jobs.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Tom Augspurger (https://github.com/TomAugspurger)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants