Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if nightlies have succeeded recently enough #1772

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 20, 2024

Description

Contributes to rapidsai/build-planning#127

This PR cannot be merged unless nightly CI has passed within the past 7 days, so if it remains unmerged that will itself be an indication that nightly CI needs fixing.

@vyasr vyasr added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Dec 20, 2024
Copy link

copy-pr-bot bot commented Dec 20, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@vyasr vyasr marked this pull request as ready for review December 20, 2024 20:55
@vyasr vyasr requested a review from a team as a code owner December 20, 2024 20:55
@vyasr vyasr requested a review from bdice December 20, 2024 20:55
@vyasr vyasr added improvement Improvement / enhancement to an existing function and removed improvement Improvement / enhancement to an existing function labels Dec 20, 2024
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyasr I'm not seeing the CI output I expected here. It doesn't show any information that indicates that it actually checked the nightly status. Is the action expected to be silent?

@vyasr
Copy link
Contributor Author

vyasr commented Dec 20, 2024

Yes, it is currently silent. If we want a positive notification we could add a corresponding print here.

@bdice
Copy link
Contributor

bdice commented Dec 21, 2024

Let’s add some logging, like “Checking repo X for workflow Y… workflow Y passed on 2024-12-20 12:34:56.” The silence made me unsure whether it had done any actual work.

@vyasr
Copy link
Contributor Author

vyasr commented Dec 30, 2024

Let’s add some logging, like “Checking repo X for workflow Y… workflow Y passed on 2024-12-20 12:34:56.” The silence made me unsure whether it had done any actual work.

Done in rapidsai/shared-actions#35, can be seen in the rerun of the job on this PR.

@vyasr vyasr requested a review from bdice December 30, 2024 18:39
@vyasr
Copy link
Contributor Author

vyasr commented Dec 30, 2024

@bdice we should be set here now.

@bdice
Copy link
Contributor

bdice commented Jan 2, 2025

I have a question here that I'd like to address before approving this: rapidsai/shared-actions#35 (comment)

@vyasr
Copy link
Contributor Author

vyasr commented Jan 3, 2025

For the record, the request was addressed in rapidsai/shared-actions#37.

@vyasr
Copy link
Contributor Author

vyasr commented Jan 3, 2025

/merge

@rapids-bot rapids-bot bot merged commit 0a8e920 into rapidsai:branch-25.02 Jan 3, 2025
62 checks passed
@vyasr vyasr deleted the feat/check_nightly_ci branch January 3, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants