-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if nightlies have succeeded recently enough #1772
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vyasr I'm not seeing the CI output I expected here. It doesn't show any information that indicates that it actually checked the nightly status. Is the action expected to be silent?
Yes, it is currently silent. If we want a positive notification we could add a corresponding print here. |
Let’s add some logging, like “Checking repo X for workflow Y… workflow Y passed on 2024-12-20 12:34:56.” The silence made me unsure whether it had done any actual work. |
Done in rapidsai/shared-actions#35, can be seen in the rerun of the job on this PR. |
@bdice we should be set here now. |
I have a question here that I'd like to address before approving this: rapidsai/shared-actions#35 (comment) |
For the record, the request was addressed in rapidsai/shared-actions#37. |
/merge |
Description
Contributes to rapidsai/build-planning#127
This PR cannot be merged unless nightly CI has passed within the past 7 days, so if it remains unmerged that will itself be an indication that nightly CI needs fixing.