java: use GCS mirror for Maven, other small changes#992
Conversation
jameslamb
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
| -Daether.connector.basic.downstreamThreads=1 | ||
| -Daether.transport.http.retryHandler.count=5 | ||
| -Daether.transport.http.retryHandler.interval=10000 | ||
| -Dmaven.wagon.http.retryHandler.count=5 |
There was a problem hiding this comment.
See NVIDIA/cuvs#2253 (comment) for an explanation of these flags.
I believe comments are not allowed in this file because its contents are passed literally to mvn.
There was a problem hiding this comment.
I don't know if it's worth a CI re-run, but one option (maybe) would be to document the options in a README inside the .mvn directory. But that shouldn't block this.
There was a problem hiding this comment.
Yeah fair. I went back and forth on that and settled on not doing it because I thought the git blame pointing back to this PR + the mostly informative names was probably enough to communicate the intent.
I'm gonna treat that "I don't know" and "(maybe)" as you also being unsure about how to handle this 😂
Think I'll just merge it as-is.
| <version>3.1.0</version> | ||
| <configuration> | ||
| <createDirs>true</createDirs> | ||
| </configuration> |
There was a problem hiding this comment.
createDirs is not a valid property for maven-clean-plugin: https://github.com/search?q=repo%3Aapache%2Fmaven-clean-plugin%20%22createDirs%22&type=code
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter-engine</artifactId> | ||
| <version>5.4.2</version> | ||
| <version>${junit.version}</version> |
There was a problem hiding this comment.
This version is stored a few lines up:
Line 26 in 37790a1
Reusing that value reduces the risk of inconsistencies.
| <plugin> | ||
| <artifactId>maven-project-info-reports-plugin</artifactId> | ||
| <version>3.0.0</version> | ||
| </plugin> |
There was a problem hiding this comment.
These don't have entries in <plugins> so don't need entries in <pluginManagement>.
jameslamb
changed the title
gforsyth
left a comment
gforsyth
left a comment
There was a problem hiding this comment.
Just the one thought, but looks good. Thanks @jameslamb !
| -Daether.connector.basic.downstreamThreads=1 | ||
| -Daether.transport.http.retryHandler.count=5 | ||
| -Daether.transport.http.retryHandler.interval=10000 | ||
| -Dmaven.wagon.http.retryHandler.count=5 |
There was a problem hiding this comment.
I don't know if it's worth a CI re-run, but one option (maybe) would be to document the options in a README inside the .mvn directory. But that shouldn't block this.
|
/merge |
2 participants
Contributes to rapidsai/build-planning#297
RAPIDS projects using NVIDIA-hosted GitHub Actions runners have been getting rate-limited by Maven Central. Similar to NVIDIA/cuvs#2253, this proposes fixing that by using the same read-only Maven mirror that Apache Orc, Lucene, Spark and others use in their builds (https://storage-download.googleapis.com/maven-central/index.html).
Other changes:
mvnoptions to request packages more slowly and wait longer between retriespre-commithookscheck-xmlhook to validate thatpom.xmlare valid XML docspom.xmlmaintenance (see comments)