Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Skip WholeGraph Tests if GPU PyTorch Unavailable #4820

Open
wants to merge 2 commits into
base: branch-25.02
Choose a base branch
from
Open

[BUG] Skip WholeGraph Tests if GPU PyTorch Unavailable #4820

wants to merge 2 commits into from

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Dec 9, 2024 •
edited
Loading

Skips WholeGraph tests if GPU PyTorch is not available. Required to get tests passing on ARM. In the future, we should move all WholeGraph-dependent code, as well as the bulk sampling API, into cugraph-gnn so these errors do not continue.

@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner December 9, 2024 22:41
@alexbarghi-nv alexbarghi-nv self-assigned this Dec 9, 2024
@github-actions github-actions bot added the python label Dec 9, 2024
@alexbarghi-nv alexbarghi-nv added bug Something isn't working non-breaking Non-breaking change and removed python labels Dec 9, 2024
jameslamb
jameslamb approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

For both the title and description, I think you mean "GPU PyTorch" not "CPU PyTorch", right?

@jameslamb
Copy link
Member

Linking the related conversation: #4817

@alexbarghi-nv alexbarghi-nv changed the title [BUG] Skip WholeGraph Tests if CPU PyTorch Unavailable [BUG] Skip WholeGraph Tests if GPU PyTorch Unavailable Dec 10, 2024
@alexbarghi-nv
Copy link
Member Author

Thank you!

For both the title and description, I think you mean "GPU PyTorch" not "CPU PyTorch", right?

Yes, I just corrected it.

@alexbarghi-nv
Copy link
Member Author

I think we will resolve these sorts of issues for good with #4822

@jameslamb
Copy link
Member

This missed 24.12, retargeting it at 25.02.

@jameslamb jameslamb changed the base branch from branch-24.12 to branch-25.02 December 12, 2024 15:44
@jameslamb jameslamb requested review from a team as code owners December 12, 2024 15:44
acostadon
acostadon approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-actions github-actions bot added the conda label Dec 12, 2024
@github-actions github-actions bot removed the conda label Dec 12, 2024
@jameslamb
Copy link
Member

Re-targeting to branch-25.02 introduced some conflicts in the history, I rebased and force-pushed on this branch to resolve those.

@alexbarghi-nv alexbarghi-nv mentioned this pull request Dec 17, 2024
Open
@jameslamb
Copy link
Member

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostadon acostadon acostadon approved these changes

@jameslamb jameslamb jameslamb approved these changes

@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA was automatically assigned from rapidsai/packaging-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@alexbarghi-nv alexbarghi-nv

Labels
bug Something isn't working non-breaking Non-breaking change python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexbarghi-nv @jameslamb @acostadon