java: use GCS mirror for Maven Central, other small changes#22969
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
| <junit.version>5.4.2</junit.version> | ||
| <ai.rapids.refcount.debug>false</ai.rapids.refcount.debug> | ||
| <ai.rapids.cudf.nvtx.enabled>false</ai.rapids.cudf.nvtx.enabled> | ||
| <native.build.path>${basedir}/target/cmake-build</native.build.path> |
There was a problem hiding this comment.
This is overridden a few lines down in this same block... think it's a left-behind duplicate that can be removed.
| <plugin> | ||
| <groupId>org.sonatype.plugins</groupId> | ||
| <artifactId>nexus-staging-maven-plugin</artifactId> | ||
| <version>1.6.7</version> | ||
| <extensions>true</extensions> | ||
| <configuration> | ||
| <serverId>ossrh</serverId> | ||
| <nexusUrl>https://oss.sonatype.org/</nexusUrl> | ||
| <autoReleaseAfterClose>false</autoReleaseAfterClose> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
I suspect this is just unused... oss.sonatype.org was shut down.
$ curl -I https://oss.sonatype.org
HTTP/2 404https://central.sonatype.org/pages/ossrh-eol/
I've seen that other release pipelines around RAPIDS don't use mvn deploy anyway, they directly hit the Sonatype API's upload endpoint. See NVIDIA/cuvs#2253 (comment)
| <plugin> | ||
| <artifactId>maven-exec-plugin</artifactId> | ||
| <version>1.6.0</version> | ||
| </plugin> |
There was a problem hiding this comment.
There's no matching entry for this in <plugins>, so I suspect we don't need one here in <pluginManagement>.
|
/ok to test |
| -Daether.connector.basic.downstreamThreads=1 | ||
| -Daether.transport.http.retryHandler.count=5 | ||
| -Daether.transport.http.retryHandler.interval=10000 | ||
| -Dmaven.wagon.http.retryHandler.count=5 |
There was a problem hiding this comment.
See NVIDIA/cuvs#2253 (comment) for an explanation of these flags.
I believe comments are not allowed in this file because its contents are passed literally to mvn.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR migrates Maven mirror configuration from a CI-specific ChangesMaven Mirror Configuration Migration and CI Hardening
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/merge |
Description
Contributes to rapidsai/build-planning#297
Follow-up to #22875
Java CI on projects using NVIDIA's hosted GitHub Actions runners have been getting rate-limited by Maven Central. Similar to NVIDIA/cuvs#2253, this proposes fixing that by using the same read-only Maven mirror that Apache Orc, Lucene, Spark and others use in their builds (https://storage-download.googleapis.com/maven-central/index.html).
#22875 did that by adding a custom
settings.xmland passing it tomvn -s. This moves those settings in to the project'spom.xmlso it'll affect allmvninvocations, not just that script.Other changes:
mvnoptions to request packages more slowly and wait longer between retriescheck-xmlpre-commit hook to validate thatpom.xmlis valid XMLpom.xmlcleanup (see comments)Checklist