-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add check for prometheus pprof endpoints #19752
Conversation
As the checks for Tested successfully in a known good configuration:
Exposed
As the underlying issue is due to the pprof library, and the functionality is mapped to a static route |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @h00die, the code seems okay, only with one small detail. If there's PoC for denial of service, it might be good to consider making separate module with this PoC as well. Is the underlying issue for Prometheus DoS/Info Disclosure same as for other Kubernetes systems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any issues with the code.
Release NotesThis enhancement adds checks for presence of |
Fix #19728
Adds a check for the two prometheus modules to check for the newly documented
/debug/pprof/
endpoint that can have an information disclosure and DoS.Verification
:lastest
still works for both.use modules/auxiliary/gather/prometheus_node_exporter_gather
run
use modules/auxiliary/gather/prometheus_api_gather
run