Update dns resolution for socks proxies #19683
Conversation
adfoster-r7
force-pushed
the
update-dns-resolution-for-socks-proxies
branch
3 times, most recently
from
bb3d05c to
2c78d21
Compare
lib/msf/core/opt_proxies.rb
Outdated
There was a problem hiding this comment.
Will extract out to a separate PR; I noticed it's possible to assign invalid values to the proxies datastore option. This should tighten things up, but the UX still isn't great IMO
lib/msf/core/rhosts_walker.rb
Outdated
| # @return [Boolean] True if DNS resolution should be performed the RHOST values, false otherwise | ||
| def perform_dns_resolution?(datastore) | ||
| # If a socks proxy has been configured, don't perform DNS resolution - so that it instead happens via the proxy | ||
| !(datastore['PROXIES'].to_s.include?(Rex::Socket::Proxies::ProxyType::SOCKS4) || datastore['PROXIES'].to_s.include?(Rex::Socket::Proxies::ProxyType::SOCKS5)) |
There was a problem hiding this comment.
It's probably time we differentiate between SOCKS4 and SOCKS4A since 4 doesn't support hostnames while 4A and 5 do and that's what we're doing here.
There was a problem hiding this comment.
Let's do HTTP and socks5; and we can circle back to implementing socks4a if that comes up (as we explicitly resolve locally in rex-socket with the current implementation), similarly with the SAPNI support
adfoster-r7
force-pushed
the
update-dns-resolution-for-socks-proxies
branch
3 times, most recently
from
a7c53a7 to
0a41f51
Compare
adfoster-r7
force-pushed
the
update-dns-resolution-for-socks-proxies
branch
from
0a41f51 to
452a386
Compare
adfoster-r7
added
the
attic
|
Thanks for your contribution to Metasploit Framework! We've looked at this pull request, and we agree that it seems like a good addition to Metasploit, but it looks like it is not quite ready to land. We've labeled it What does this generally mean? It could be one or more of several things:
We would love to land this pull request when it's ready. If you have a chance to address all comments, we would be happy to reopen and discuss how to merge this! |
|
I don't have the cycles for this, passing over to @smcintyre-r7 |
Improves #19641
Requires rapid7/rex-socket#69
Update dns resolution for socks proxies. Now local DNS resolution will be skipped on the host machine and deferred to any configured socks proxies, i.e. with
setg proxies socks5:127.0.0.1:1080Verification
Ensure CI passes