Poll Interval Parameter #32
Open
+71
−4,701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmayne-r7
reviewed
Mar 21, 2023
|
|
||
| # Optional: | ||
| # The maximum amount of time (in minutes) the scan is allowed to run before canceling and failing the job. | ||
| scan-timeout-mins: "15" |
There was a problem hiding this comment.
Is this a reasonable default for the use case? I'm not sure if the use case targets mainly cloud or on premise engines, but during busy periods, scans may queue for a time before execution
There was a problem hiding this comment.
Probably not actually tbh - now I've used this in practice these scans are LONG.
So long in fact I'm starting to question if this tool is really appropriate to be used as a pipeline tool in this way.
Setting of scans on production etc seems sensible, but if one has to wait often an hour or more for a scan to complete - how useful is it as a bit of developer feedback really?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
poll-interval-minsto the interface and pass that through toScanToolsif suppliedNote: I've trried to emulate the existing patterns where possible - made the poll-inverval to be in mins to be consistent with the rest of the public interface and then multiplied up in place (same as the timeout is). By no means saying this is the right thing to do, but it it at least consistent now.
Testing
Untested as of now - I presume you'll want to check this to your own satisfaction before merging.