USD-2054 Upgrade Iceberg to 1.6.1 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat and therefore ts_us must lose its precision
jadams-r7
force-pushed
the
USD-2054/upgrade-iceberg
branch
from
73b4897 to
33b3479
Compare
ebieker-r7
reviewed
Feb 11, 2025
| @@ -179,7 +179,7 @@ public void testCommitResponseBecomesDataWrittenPartitioned() { | |||
| Types.NestedField.optional( | |||
| 10_304, | |||
| "delete_files", | |||
| Types.ListType.ofRequired(10_304, DataFile.getType(spec.partitionType()))))); | |||
| Types.ListType.ofRequired(10_305, DataFile.getType(spec.partitionType()))))); | |||
There was a problem hiding this comment.
I can't find the exact change in Iceberg but it looks like somewhere there was a change adding stricter validation for schema field IDs to prevent ID collisions and therefore the parent and optional field will now have different IDs.
Closed PR on main to upgrade Iceberg: databricks#313
| @@ -265,7 +265,7 @@ public void testShouldDeduplicateDeleteFilesBeforeAppending() { | |||
| Assertions.assertEquals(1, snapshots.size()); | |||
|
|
|||
| Snapshot snapshot = snapshots.get(0); | |||
| Assertions.assertEquals(DataOperations.OVERWRITE, snapshot.operation()); | |||
| Assertions.assertEquals(DataOperations.DELETE, snapshot.operation()); | |||
There was a problem hiding this comment.
same here - did some functionality change that required us to change tests?
There was a problem hiding this comment.
In Iceberg 1.6.0 there was a change that means this is now a delete, I believe this is the PR: apache/iceberg#10123
Closed PR on main to upgrade Iceberg: databricks#313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rapid7.atlassian.net/browse/USD-2054
Includes: