Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for moving forward tabs #860

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Conversation

aymanbagabas
Copy link
Contributor

This adds support for moving forward tabs in the grid using CSI n I. This sequence behaves like using tabs \t but also accepts a count argument to move multiple tabs forward.

@raphamorim
Copy link
Owner

Nicee!! Thank you @aymanbagabas for the PR <3
Would you mind update the changelog in https://raphamorim.io/rio/docs/releases ?

Also noticed that the docs is already marking CSI n as supported https://raphamorim.io/rio/docs/escape-sequence-support

@aymanbagabas
Copy link
Contributor Author

Nicee!! Thank you @aymanbagabas for the PR <3 Would you mind update the changelog in https://raphamorim.io/rio/docs/releases ?

I updated the commit to fix damaging the cursor and include release notes.

Also noticed that the docs is already marking CSI n as supported https://raphamorim.io/rio/docs/escape-sequence-support

It was ignored. I also opened a PR in alacritty/alacritty#8377

This adds support for moving forward tabs in the grid using `CSI n I`.
This sequence behaves like using tabs `\t` but also accepts a count
argument to move multiple tabs forward.
@raphamorim
Copy link
Owner

It was ignored. I also opened a PR in alacritty/alacritty#8377

Yea, I was aware it was broken but i thought the docs were mentioning but no 😢 👍

It was ignored. I also opened a PR in alacritty/alacritty#8377

Sounds good, Rio actually doesn't care about damaging cursor entirely (they use to compare changes) rio does in a different format.

Thank you!! merging on green

@raphamorim raphamorim merged commit f048daa into raphamorim:main Dec 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants