Skip to content

Sender matches sender#66

Open
mlsad3 wants to merge 1 commit intoranmocy:mainfrom
mlsad3:sender-matches-sender
Open

Sender matches sender#66
mlsad3 wants to merge 1 commit intoranmocy:mainfrom
mlsad3:sender-matches-sender

Conversation

@mlsad3
Copy link
Copy Markdown
Contributor

@mlsad3 mlsad3 commented Aug 5, 2022

Currently Sender only matches on 'from'. This PR resolves #35 by making Sender match:

  • reply_to
  • from
  • sender
  • X-Original-Sender

This is similar to the functionality we have in receiver, which matches 'to', 'cc', 'bcc', and 'list'.

We also speed up analysis by switching from getRawContent to getHeader.

NOTE: This utilizes @aaronj1335 's Utils PR (or I could not run anything).

Currently Sender only matches on 'from'. This resolves Issue ranmocy#35
by making Sender match:
 - reply_to
 - from
 - sender
 - X-Original-Sender

This is similar to the functionality we have in `receiver`,
which matches 'to', 'cc', 'bcc', and 'list'.

We also speed up analysis by switching from getRawContent to
getHeader.
@mlsad3 mlsad3 force-pushed the sender-matches-sender branch from 83e7f29 to 4b31f5b Compare August 19, 2022 01:26
@mlsad3
Copy link
Copy Markdown
Contributor Author

mlsad3 commented Nov 8, 2022

Hi @ranmocy ,

Any thoughts on this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sender match matches on from vs sender header

1 participant